Use map coordinates for spraying #9505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TekuNut
commented
Jul 6, 2022
metalgearsloth
previously requested changes
Jul 10, 2022
github-actions
bot
added
the
S: Needs Review
ElectroJr
dismissed
metalgearsloth’s stale review
Seems like it was all addressed
|
I still saw some issues but I'll make a pr later. |
|
Oh, my bad. Should probably have waited. I guess we could also just revert it? |
|
It's fine it'll take me 2 minutes. |
rbertoche
pushed a commit
to rbertoche/space-station-14
that referenced
this pull request
Oct 1, 2022
* Saltern Disablers (space-wizards#9492) * Atlas Disablers (space-wizards#9493) * Update hardsuits.yml (space-wizards#9494) * Makes storage insertion failure more explicit (space-wizards#9465) * Automatic changelog update * Disablers on Delta (space-wizards#9509) * Disablers on Waystation (space-wizards#9510) * Convert piped atmos entity visualizers (space-wizards#9200) * Make explosive armor multiplicative and not additive (space-wizards#9498) * Automatic changelog update * Fix stunbaton stun sounds (space-wizards#9511) * Add deletion checks to verb execution (space-wizards#9507) * Fix pipe net null error (space-wizards#9508) * Make ghost role names default to entity name (space-wizards#9478) * Play tap.ogg when no damage is being done (space-wizards#9489) * Automatic changelog update * Splitstation Update 06 July 2022 (space-wizards#9495) * Pillar Update (space-wizards#9504) * Light Lighthouse Update (space-wizards#9503) * Automatic changelog update * Prevent erroneous materials from being placed in lathes. (space-wizards#9454) Co-authored-by: metalgearsloth <[email protected]> * Automatic changelog update * Disable ambience default again (space-wizards#9442) * Emergency light goodies (space-wizards#9352) Co-authored-by: Jacob Tong <[email protected]> * Automatic changelog update * Fix Practice Shotgun Shells (space-wizards#9516) * Automatic changelog update * Satiety tweaks (space-wizards#9519) * Satiety tweaks * actually lets do this * Automatic changelog update * Separate jetpack movement speed modifier (space-wizards#9363) * Content changes required for recursive deletion changes (space-wizards#9316) * Automatic changelog update * Textures to make lamps mappable to East/West. (space-wizards#9414) Co-authored-by: Jeff <[email protected]> * Pizza box 1984 (space-wizards#9521) * Pizza box 1984 * todo * Automatic changelog update * Probably fix ghost overlays (space-wizards#9529) * Fix & speed up explosion lookup (space-wizards#9526) * Speed up explosion lookup * Ah. Fuck. * Disease Stages But Epic (space-wizards#9043) Co-authored-by: metalgearsloth <[email protected]> Co-authored-by: metalgearsloth <[email protected]> * Automatic changelog update * Adds station filter for alert level change sound (space-wizards#9533) * FixVacuum does not replace tile air if there are no adjacent tiles. (space-wizards#9535) * Fix adjacent tile atmosphere creation using the wrong coordinates. (space-wizards#9539) * Automatic changelog update * Make wieldable use entity position (space-wizards#9538) * sprite fix (space-wizards#9542) * Automatic changelog update * Add SoftMaxPlayers to status response for launcher use (space-wizards#9365) * Automatic changelog update * Fix T-ray scanner flickering (space-wizards#9544) * Automatic changelog update * Fix a bunch of warnings (space-wizards#9528) * BEHOLD! The MagiVend! (space-wizards#9440) * Magivend Sprites, and Entity stuffs * Oopsie! * Automatic changelog update * Dispense hot tea into teacup instead of glass (space-wizards#9541) * Automatic changelog update * Fireaxe resprite (space-wizards#9302) * fieraxe * traitor-fireaxe * Automatic changelog update * Marathon Update 2.4 (space-wizards#9553) * Fix space-wizards#9549 * Automatic changelog update * Bullet impact effects (space-wizards#9530) * Automatic changelog update * Fix force-feeding pills (space-wizards#9554) * Automatic changelog update * China Lake Buff (space-wizards#9543) * Automatic changelog update * Shuttle announces its docking direction (space-wizards#9564) * Shuttle announces its docking direction * Consider COM juusssttt in case * Fix nearby warping (space-wizards#9565) * Automatic changelog update * Jetpack QOL tweaks (space-wizards#9563) * Automatic changelog update * Fix drink system double-refunding solutions on failure (space-wizards#9569) * Automatic changelog update * Visual popup types (space-wizards#9523) * Visual popup types * Pass over `PopupCoordinates` and `PopupCursor` * `PopupEntity` pass * Disease and reagent popup pass * COLOUR * Automatic changelog update * Specifiable dock colours + stripeback displays (space-wizards#9566) * Visual popup addendum (space-wizards#9570) * Add egg laying + chicken/duck improvements (space-wizards#9518) * Disable emergency light ambience by default (space-wizards#9571) * splitstation minor update (emergency lights) (space-wizards#9572) * Making smites funnier (space-wizards#9524) * Automatic changelog update * Bagel E Lights (space-wizards#9573) * Update submodule (space-wizards#9574) * Injector sprite fix (space-wizards#9011) * Automatic changelog update * marathon e lights (space-wizards#9575) * Change yellow alert elight color to goldenrod (space-wizards#9577) * Evac Shuttle Fans (space-wizards#9578) * Order manifests for shuttle orders. Now with item names and approver info. (space-wizards#9464) Co-authored-by: Kara <[email protected]> * Automatic changelog update * Marathon Ore Processor and misc (space-wizards#9580) * Kudzu nerf (space-wizards#9576) * Automatic changelog update * Convert Remaining Atmos Appearance Visualizers (space-wizards#9582) * Convert atmos plaque to generic visualizer Use generic visualizer for atmos plaque. Also enables zumos plaque to appear. * Convert gas canister connecters * Remove manual layer creation * Remove gas canister visualizer * Convert gas analyzers to generic visualizers * Convert fire visualizer * Fix layers on plasma and air canisters * Remove commented out fire visualizer in barricades * Add documentation for fire visuals component * Remove redundant visualizer for milkalyzer * Remove rogue item group * Knock on shutters (space-wizards#9586) * Automatic changelog update * Update battery_guns.yml (space-wizards#9581) * Automatic changelog update * Shards damage barefoot users + steptrigger-related general cleanup (space-wizards#9585) * Automatic changelog update * Client command perms cleanup. (space-wizards#9599) * Update identification_cards.yml (space-wizards#9603) * public method to add/subtract from cargo bank account (space-wizards#9614) * Forensics QOL (Autolabeling of pads and reports) (space-wizards#9610) * Automatic changelog update * Allow non-humanoid roles (space-wizards#9604) * Fix medical techfab and add unused bodybag recipe to it (space-wizards#9607) * bodybags printable in medical techfab * fix medical techfab * Automatic changelog update * Lamp Plushie (space-wizards#9118) * Update meta.json * Add files via upload * Update toys.yml * Update toy.yml * Update toys.yml * Id[entity] 2.0 (real) (space-wizards#9612) * starter API * network ID cards * Port more stuff from old identity * Re-implement identity representation + name updating * move * proper name returning for `IdentityName` * move everything important to server, give in to temptation * shared / server / client split sadly. move ensure to shared and spawn to server * identity update queueing + identityblocker * fixes * and just like that it's usable for admins * huge identity pass * pass dos * jesus christ * figs :D * fuck u * fix bad merge. Co-authored-by: Moony <[email protected]> * Automatic changelog update * Event refactor (space-wizards#9589) * Station event refactor * Remove clientside `IStationEventManager` we can just use prototypes * Basic API idea * Cruft * first attempt at epicness * okay yeah this shit is really clean * sort out minor stuff * Convert `BreakerFlip` * `BureaucraticError` + general cleanup * `DiseaseOutbreak` * `FalseAlarm` * `GasLeak` * `KudzuGrowth` * `MeteorSwarm` * `MouseMigration` * misc errors * `PowerGridCheck` * `RandomSentience` * `VentClog` * `VentCritters` * `ZombieOutbreak` * Rewrite basic event scheduler * Minor fixes and logging * ooooops * errors + fix * linter * completions, `RuleStarted` property, update loop fixes * Tweaks * Fix space-wizards#9462 * Basic scheduler update fix, and fixes space-wizards#8174 * Add test * UI cleanup * really this was just for testing * Fixes Blocking bugs (space-wizards#9424) * Fixes Riot shield bugs * Removes redundant check and extra parenthesis * Requested changes * Prevent block with another shield if already blocking. * Automatic changelog update * Fix space mob burning (space-wizards#9615) * Small identity fixes (space-wizards#9617) * More nukie tweaks (space-wizards#9618) * Automatic changelog update * Fixed typo in lobby (space-wizards#9630) * Automatic changelog update * Actually include clientCommandPerms.yml in client builds. (space-wizards#9632) * Automatic changelog update * Do not hardcode salvage magnet channel (space-wizards#9633) * Fixed PDA not spawning with the correct light (space-wizards#9623) * Fixed PDA not spawning with the correct light * Fixed indentation * Forgot I had to use camelCase * Automatic changelog update * Fix a bug where toggleready returns an exception when provided with the wrong number of arguments (space-wizards#9631) * Use map coordinates for spraying (space-wizards#9505) * Adds blinding + blindfolds (space-wizards#8688) * Adds blinding + blindfolds * Don't break examining lol * moment * fix toggle lights behavior * move checks around * Sloth review * Added a salvage funny * review * woops * Switch circle shader Co-authored-by: wrexbe <[email protected]> * Automatic changelog update * Cleans up warning line decals (space-wizards#8731) * letsa go * indentations * added back old decals * this thing * maybe this * jfc * Toilet fixes (space-wizards#9609) * Automatic changelog update * Update misleading Phalanximine description to accurate one (space-wizards#9625) * Automatic changelog update * Kvass (space-wizards#9082) * add kvass * nevermind * forgot about double 's' * Update tanks.yml * gotovo * Update meta.json * Automatic changelog update * Clarify on ways to get help from other players (space-wizards#9627) * Update DiseaseTest (space-wizards#9639) Effects / cures are indices not the threshold * Probably fix thirst mispredict (space-wizards#9656) * Probably fix thirst mispredict * thanks rider * Fix interaction outline jankiness at high speeds (space-wizards#9653) Converting mouse to eye pos is better done after the eye has its frameupdate. * Automatic changelog update * Food and Beverage Spawners (space-wizards#9547) * Textures to make lamps mappable to East/West. * Adds various rng food and beverage spawners for mapping. Also adds a smaller icon for rndm arcade machine because the other was triggering people. * Fix * ugh * edits * Oops, missed a couple xenos Co-authored-by: Jeff <[email protected]> * Add admin verb for respawning a player (space-wizards#9666) * You can now unanchor and destroy the robot showcase (space-wizards#9668) * Automatic changelog update * Cargo Shuttle Update (space-wizards#9679) * Revert "Fireaxe resprite" (space-wizards#9676) * Revert "Adds blinding + blindfolds (space-wizards#8688)" (space-wizards#9689) This reverts commit 7a7ab5e. * EntityStorage ECS (space-wizards#9291) * Automatic changelog update * Update ContainerOcclusionTest.cs (space-wizards#9692) * Identity fixes (space-wizards#9701) * Healing tweaks (space-wizards#9697) * Automatic changelog update * Generic morgue visualizer (space-wizards#9696) * Remove IActivate (space-wizards#9705) * git mv * purge IActivate * File scoped NS * Update misc.yml (space-wizards#9691) * cltohes (space-wizards#9680) * Update submodule to 0.28.5.0 (space-wizards#9708) * mathaotnont (space-wizards#9711) * bagl... (space-wizards#9710) * Traitor deathmatch ecs (space-wizards#9714) * salty (space-wizards#9712) * Machine frame ECS (space-wizards#9713) * Entity storage whitelist (space-wizards#9694) * Update common color to station announcements (space-wizards#9670) * Atlas Update 1.6 (space-wizards#9709) * Automatic changelog update * Update shards.yml (space-wizards#9644) * Remove `IInteractUsing` (space-wizards#9718) * Automatic changelog update * Remove `IAfterInteract` (space-wizards#9715) * remove gas analyzer iafterinteract * solution transfer + obsolete * cuffable * remove * dart becomestation comp fix (plus render) (space-wizards#9497) * dart becomestation comp fix * minor fixes and changes to ERT shuttle Dart * Hospital curtains add (space-wizards#9707) * curtainss * sound_mono * hotfix_curtains * Automatic changelog update * [2 lines] fix blinding (space-wizards#9690) * Adds blinding + blindfolds (space-wizards#8688) * Adds blinding + blindfolds * Don't break examining lol * moment * fix toggle lights behavior * move checks around * Sloth review * Added a salvage funny * review * woops * Switch circle shader Co-authored-by: wrexbe <[email protected]> * resolve merge conflict Co-authored-by: wrexbe <[email protected]> * Automatic changelog update * Re-implement recoil (space-wizards#9406) * Re-implement recoil Playing around with the values atm * Update constants * final tweaks * Automatic changelog update * Fix zombie percent in the round end summary (space-wizards#9682) * Make controlmob not require sentience (space-wizards#9479) * Outer clothing nerf (space-wizards#9143) * Reduced backpack to 99 size from 100 * Increase hardsuit and softsuit size * Adds ClothingOuterBaseLarge * Parenting * Changed parent base, reduced duplication * 101 the people have spoken * 100 backpack cry * Changes some things to large base 60 * Updates armour based to large * Large base slowdown 20% * Speed boost * Removed syndie eva box Duffel exists, no need * Apparently this is an eva suit * Fixed formatting * Syndie duffel boosted to 131 To fit a hardsuit plus mask and gas * Hardsuits to 121 size No more bagging * Made heavy clothing 80 * moves syndie eva box to a duffel * Automatic changelog update * Muzzle flash enhancements (space-wizards#9527) * Automatic changelog update * remove 1 taser (space-wizards#9725) * Remove some tasers (space-wizards#9727) * Packed Station Update (space-wizards#9722) * RPG-7, Kardashev rifle and Hristov heavy sniper resprites (space-wizards#9729) Co-authored-by: and_a <and_a@DESKTOP-RJENGIR> * Guard against weird renderer bug (space-wizards#9720) * Make disposal pipes use generic visualizer (space-wizards#9672) * Automatic changelog update * Add AMIV disease stages (space-wizards#9637) * Add AMIV disease stages * remove unused import * move stages to top for readability * monkey immunity to amiv * Update to use time instead of index * Revert "Update to use time instead of index" This reverts commit 6bc83b0. * add comments * rerun test * Automatic changelog update * Fix bricked welding component (space-wizards#9741) * Automatic changelog update * Make entity storage lookup range positive (space-wizards#9735) * Automatic changelog update * Add uplink command completions (space-wizards#9742) * Remove telekinesis (space-wizards#9737) * Add batch cooking (space-wizards#9359) * Automatic changelog update * Prevent content from overriding sprite shader (space-wizards#9036) * Fix disappearing decals bug (space-wizards#9608) * Automatic changelog update * Make flash prevent handheld light toggle (space-wizards#9448) Co-authored-by: Kara <[email protected]> * Bring pills back to 50 units maximum (space-wizards#9626) * Adds a nuclear pinpointer to the operative and medic operative duffel fills (space-wizards#9634) * Nerf disease outbreak (space-wizards#9640) * Automatic changelog update * Make sure dragdrop doesn't delay by a frame (space-wizards#9745) * Vapor tweaks (space-wizards#9638) * Magic staves + wands (space-wizards#9070) * Automatic changelog update * Operating table add (space-wizards#9687) * Automatic changelog update * Fix loadbp window perm issue (space-wizards#9671) * Steal condition tells you where to steal it from (space-wizards#9605) * Automatic changelog update * Add FTL destinations (space-wizards#9685) * Job-specific traitor items (space-wizards#9601) * Automatic changelog update * Proto-kinetic accelerator (space-wizards#9748) * Automatic changelog update * Update submodule to 0.28.5.1 (space-wizards#9750) * Reduce radar minimap radius (space-wizards#9673) * Ghost role probability (space-wizards#9752) * Ghost role probability * give it to regular ticks/bears too * Automatic changelog update * Smooth radar zooming (space-wizards#9753) * Automatic changelog update * Convert familiars to GhostRoleMobSpawner (space-wizards#9525) Co-authored-by: metalgearsloth <[email protected]> * Port honkbots from nyano (space-wizards#9698) * Automatic changelog update * Identity popup fixes (space-wizards#9743) * Automatic changelog update * Bartending Tweaks (space-wizards#9307) * Automatic changelog update * Nuke ops war anounce sound (space-wizards#9035) * Altars add (space-wizards#9678) * Automatic changelog update * Updated alarm sound effect (space-wizards#9756) * Updated alarm sound * Added Loop to alarm sound effect * Automatic changelog update * Bagel Update 14.3 (space-wizards#9757) * Cargo shuttle qol and fixe (space-wizards#9759) * Fix emergency shuttle docking (space-wizards#9758) Woopsy * Portable scrubbers (space-wizards#9417) * Automatic changelog update * fix up merge Co-authored-by: Emisse <[email protected]> Co-authored-by: ike709 <[email protected]> Co-authored-by: PJBot <[email protected]> Co-authored-by: TimrodDX <[email protected]> Co-authored-by: TekuNut <[email protected]> Co-authored-by: Nemanja <[email protected]> Co-authored-by: metalgearsloth <[email protected]> Co-authored-by: Leon Friedrich <[email protected]> Co-authored-by: Peptide90 <[email protected]> Co-authored-by: OldDanceJacket <[email protected]> Co-authored-by: Kara <[email protected]> Co-authored-by: Jacob Tong <[email protected]> Co-authored-by: themias <[email protected]> Co-authored-by: ChilbroBaggins <[email protected]> Co-authored-by: Jeff <[email protected]> Co-authored-by: metalgearsloth <[email protected]> Co-authored-by: Flipp Syder <[email protected]> Co-authored-by: Vera Aguilera Puerto <[email protected]> Co-authored-by: Aerocrux <[email protected]> Co-authored-by: Ablankmann <[email protected]> Co-authored-by: Deahaka <[email protected]> Co-authored-by: Myctai <[email protected]> Co-authored-by: AJCM-git <[email protected]> Co-authored-by: Marat Gadzhiev <[email protected]> Co-authored-by: Pieter-Jan Briers <[email protected]> Co-authored-by: Moony <[email protected]> Co-authored-by: keronshb <[email protected]> Co-authored-by: wrexbe <[email protected]> Co-authored-by: Duddino <[email protected]> Co-authored-by: wrexbe <[email protected]> Co-authored-by: Delete69 <[email protected]> Co-authored-by: KIBORG04 <[email protected]> Co-authored-by: Jessica M <[email protected]> Co-authored-by: lapatison <[email protected]> Co-authored-by: sBasalto <[email protected]> Co-authored-by: TaralGit <[email protected]> Co-authored-by: and_a <and_a@DESKTOP-RJENGIR> Co-authored-by: Level10Cybermancer <[email protected]> Co-authored-by: Kevin Zheng <[email protected]> Co-authored-by: ZeroDayDaemon <[email protected]> Co-authored-by: Morber <[email protected]> Co-authored-by: Kimpes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes spray system to use MapCoordinates, allowing targeting of sprayables between grids and fixing a crash when using a sprayable from a vehicle, fixing #9321.