Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unbreakable bar sign fix. #35490

Merged
merged 3 commits into from
Feb 25, 2025
Merged

Unbreakable bar sign fix. #35490

merged 3 commits into from
Feb 25, 2025

Conversation

spderman3333
Copy link
Contributor

@spderman3333 spderman3333 commented Feb 25, 2025 •
edited
Loading

About the PR

Partially fixes #35443
Make bar signs breakable, however, does not make them unanchorable.
Also adds a breakage sound (MetalGlassBreak).

Why / Balance

Technical details

Adds a Damageable component to the bar sign prototype.

Media

Requirements

Breaking changes

Changelog

🆑

  • tweak: Electronic bar signs can now be destroyed.

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. size/XS Denotes a PR that changes 0-9 lines. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Feb 25, 2025
slarticodefast
slarticodefast approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@slarticodefast slarticodefast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the bugfix!

@slarticodefast slarticodefast added S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. T: Bugfix Type: Bugs and/or bugfixes labels Feb 25, 2025
@slarticodefast slarticodefast merged commit 7ddad07 into space-wizards:master Feb 25, 2025
12 checks passed
@spderman3333 spderman3333 deleted the BreakableBarSigns branch February 25, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slarticodefast slarticodefast slarticodefast approved these changes

Assignees
No one assigned
Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. size/XS Denotes a PR that changes 0-9 lines. T: Bugfix Type: Bugs and/or bugfixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bar signs are indestructible and unanchorable
2 participants
@spderman3333 @slarticodefast