Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bar signs are indestructible and unanchorable #35443

Closed
K-Dynamic opened this issue Feb 24, 2025 · 3 comments · Fixed by #35490
Closed

Bar signs are indestructible and unanchorable #35443

K-Dynamic opened this issue Feb 24, 2025 · 3 comments · Fixed by #35490
Labels
A: General Interactions Area: General in-game interactions that don't relate to another area. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Requires Content PR Status: Requires a change to SS14, for which there is no open PR currently. T: Bugfix Type: Bugs and/or bugfixes

Comments

@K-Dynamic
Copy link
Contributor

Description

Bar signs straight up can't be destroyed or deconstructed.

You can move them around after deconstructing or minibombing the tile they're on but they can't be anchored.

Reproduction

  1. Attempt to destroy bar sign with any object (bang stick, PKA, AKMS, etc.)
  2. Attempt to deconstruct the bar sign.
@github-actions github-actions bot added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Feb 24, 2025
@lzk228 lzk228 added T: Bugfix Type: Bugs and/or bugfixes P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. A: General Interactions Area: General in-game interactions that don't relate to another area. S: Requires Content PR Status: Requires a change to SS14, for which there is no open PR currently. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Feb 24, 2025
@spderman3333
Copy link
Contributor

I'm comparing the bar sign prototype versus other breakable things, like vending machines or crates, and the only thing I notice is that the bar sign lacks a PlaySoundBehavior after the DoActBehavior. While I don't think this is the issue, I'll test it out.

@spderman3333
Copy link
Contributor

I'm comparing the bar sign prototype versus other breakable things, like vending machines or crates, and the only thing I notice is that the bar sign lacks a PlaySoundBehavior after the DoActBehavior. While I don't think this is the issue, I'll test it out.

Okay, that was not causing the issue.

@spderman3333
Copy link
Contributor

I figured out the issue. All of bar_sign's parents do not contain a damageable type. Therefore, after implementing it in bar_sign, it can be broken (though just disappears for now, doesn't drop anything).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: General Interactions Area: General in-game interactions that don't relate to another area. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Requires Content PR Status: Requires a change to SS14, for which there is no open PR currently. T: Bugfix Type: Bugs and/or bugfixes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants