Fix hitscan reflection ignoring reflects param #34616
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
S: Needs Review
|
fwiw this is a near-exact duplicate of #34203 |
Oh, for some reason couldn't find it. Closing then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Reflection code ignores
reflectiveandreflectsparams in the reflector and hitscan when handling user reflection (when character reflects using sword or armor). It's not true for general reflection (when character has componentReflectionComponent), so I think it's a bug.Why / Balance
It's a bug.
Technical details
Moved reflection check from event handlers to
TryReflectHitscan.TryReflectProjectilehas the similar check.Media
res.mp4
Requirements
Breaking changes
None, it's a bug
Changelog
There's no items that were affected by this, so no CL.