Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes hitscan weapons not respecting reflectTypes #34203

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixes hitscan weapons not respecting reflectTypes #34203

wants to merge 3 commits into from

Conversation

ruddygreat
Copy link

@ruddygreat ruddygreat commented Jan 3, 2025 •
edited
Loading

About the PR

Adds a reflectType check in TryReflectHitscan, before now hitscan weapons were reflectable no matter what.
was seemingly missed by #29326?

Why / Balance

Was noticed while making something for the fork I play on, figured it's just a useful bugfix

Technical details

very minor change, unsure what to write

Media

see above, unsure how to showcase

Requirements

@github-actions github-actions bot added size/XS Denotes a PR that changes 0-9 lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Needs Review Status: Requires additional reviews before being fully accepted labels Jan 3, 2025
@github-actions github-actions bot added size/S Denotes a PR that changes 10-99 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Jan 3, 2025
@beck-thompson beck-thompson added T: Bugfix Type: Bugs and/or bugfixes P3: Standard Priority: Default priority for repository items. D2: Medium Difficulty: A good amount of codebase knowledge required. A: Combat Area: Combat features and changes, balancing, feel A: Core Tech Area: Underlying core tech for the game and the Github repository. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 4, 2025
@ruddygreat ruddygreat mentioned this pull request Jan 24, 2025
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metalgearsloth metalgearsloth Awaiting requested review from metalgearsloth metalgearsloth is a code owner

Assignees
No one assigned
Labels
A: Combat Area: Combat features and changes, balancing, feel A: Core Tech Area: Underlying core tech for the game and the Github repository. D2: Medium Difficulty: A good amount of codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted size/S Denotes a PR that changes 10-99 lines. T: Bugfix Type: Bugs and/or bugfixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruddygreat @beck-thompson