Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cabinetification #34293

Merged
merged 44 commits into from
Feb 4, 2025
Merged

Cabinetification #34293

merged 44 commits into from
Feb 4, 2025

Conversation

ps3moira
Copy link
Contributor

@ps3moira ps3moira commented Jan 8, 2025

About the PR

Resprited most items meant to be three-dimensional to be in cabinet perspective (cabinetification) instead of 3/4ths. Credit to @Flareguy for the initial box resprite and help

Why / Balance

To create consistency with objects that are supposed to be three-dimensional with a consistent perspective. I removed the olive box sprite because it was only used for the MRE and doesn't have any use outside that so just made it use the regular box. I removed the ID box because no one uses it and uses the PDA box instead.

Media

image

Changelog
🆑

  • tweak: Changed 3D item sprites to cabinet perspective

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/XS Denotes a PR that changes 0-9 lines. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 8, 2025
Copy link
Contributor

github-actions bot commented Jan 8, 2025

RSI Diff Bot; head commit 5ca3603 merging into c0fcf4b
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Consumable/Food/Baked/donkpocket.rsi

State Old New Status
banana-box Modified
berry-box Modified
box Modified
carp-box Modified
dink-box Modified
pizza-box Modified
spicy-box Modified
stonk-box Modified
teriyaki-box Modified

Resources/Textures/Objects/Consumable/Food/Baked/donut.rsi

State Old New Status
box-open Modified
box Modified
box1 Modified
box2 Modified
box3 Modified
box4 Modified
box5 Modified
box6 Modified
pink-box1 Modified
pink-box2 Modified
pink-box3 Modified
pink-box4 Modified
pink-box5 Modified
pink-box6 Modified

Resources/Textures/Objects/Consumable/Smokeables/Cigarettes/Cartons/black.rsi

State Old New Status
inhand-left Modified
inhand-right Modified
closed Removed
open Removed
icon Added

Resources/Textures/Objects/Consumable/Smokeables/Cigarettes/Cartons/blue.rsi

State Old New Status
inhand-left Modified
inhand-right Modified
closed Removed
open Removed
icon Added

Resources/Textures/Objects/Consumable/Smokeables/Cigarettes/Cartons/green.rsi

State Old New Status
inhand-left Modified
inhand-right Modified
closed Removed
open Removed
icon Added

Resources/Textures/Objects/Consumable/Smokeables/Cigarettes/Cartons/mixed.rsi

State Old New Status
inhand-left Modified
inhand-right Modified
closed Removed
open Removed
icon Added

Resources/Textures/Objects/Consumable/Smokeables/Cigarettes/Cartons/red.rsi

State Old New Status
inhand-left Modified
inhand-right Modified
closed Removed
open Removed
icon Added

Resources/Textures/Objects/Consumable/Smokeables/Cigarettes/Packs/black.rsi

State Old New Status
closed Modified
equipped-BELT Modified
inhand-left Modified
inhand-right Modified
open Modified
trash Modified

Resources/Textures/Objects/Consumable/Smokeables/Cigarettes/Packs/blue.rsi

State Old New Status
closed Modified
equipped-BELT Modified
inhand-left Modified
inhand-right Modified
open Modified
trash Modified

Resources/Textures/Objects/Consumable/Smokeables/Cigarettes/Packs/green.rsi

State Old New Status
closed Modified
equipped-BELT Modified
inhand-left Modified
inhand-right Modified
open Modified
trash Modified

Resources/Textures/Objects/Consumable/Smokeables/Cigarettes/Packs/mixed.rsi

State Old New Status
closed Modified
equipped-BELT Modified
inhand-left Modified
inhand-right Modified
open Modified
trash Modified

Resources/Textures/Objects/Consumable/Smokeables/Cigarettes/Packs/red.rsi

State Old New Status
closed Modified
equipped-BELT Modified
inhand-left Modified
inhand-right Modified
open Modified
trash Modified

Resources/Textures/Objects/Consumable/Smokeables/Cigarettes/Packs/syndicate.rsi

State Old New Status
closed Modified
equipped-BELT Modified
inhand-left Modified
inhand-right Modified
open Modified
trash Modified

Resources/Textures/Objects/Consumable/Smokeables/Cigarettes/Packs/visualizer.rsi

State Old New Status
cig1 Modified
cig2 Modified
cig3 Modified
cig4 Modified
cig5 Modified
cig6 Modified

Resources/Textures/Objects/Decoration/present.rsi

State Old New Status
present Modified

Resources/Textures/Objects/Devices/flatpack.rsi

State Old New Status
ame-part Modified
base Modified
containment-field-generator Modified
emitter Modified
fax-machine Modified
grounding-rod Modified
icon-default Modified
overlay Modified
radiation-collector Modified
singularity-generator Modified
solar-assembly-part Modified
tesla-coil Modified
tesla-generator Modified

Resources/Textures/Objects/Materials/Scrap/generic.rsi

State Old New Status
junk-medkit-1 Modified
junk-medkit-2 Modified

Resources/Textures/Objects/Specific/Medical/firstaidkits.rsi

State Old New Status
advkit Modified
blackkit Modified
brutekit Modified
burnkit Modified
firstaid Modified
o2kit Modified
radkit Modified
toxinkit Modified
purplekit-inhand-left Removed
purplekit-inhand-right Removed
purplekit Removed

Resources/Textures/Objects/Specific/Medical/healing_toolbox.rsi

State Old New Status
icon Modified

Resources/Textures/Objects/Storage/Briefcases/briefcase_brown.rsi

State Old New Status
icon Modified

Resources/Textures/Objects/Storage/Happyhonk/clown.rsi

State Old New Status
box Modified
box-open Removed

Resources/Textures/Objects/Storage/Happyhonk/cluwne.rsi

State Old New Status
box Modified
box-open Removed

Resources/Textures/Objects/Storage/Happyhonk/mime.rsi

State Old New Status
box Modified
box-open Removed

Resources/Textures/Objects/Storage/Happyhonk/nukie.rsi

State Old New Status
box Modified
box-open Removed

Resources/Textures/Objects/Storage/boxes.rsi

State Old New Status
agrichemkit Modified
beaker Modified
bodybags Modified
bottle Modified
box Modified
box_hug Modified
box_of_doom Modified
box_of_doom_big Modified
box_science Modified
box_security Modified
boxwide Modified
boxwidetoy Modified
candle Modified
circuit Modified
clown Modified
darts Modified
disk Modified
emergencytank Modified
encryptokey Modified
envelope Modified
evidence_markers Modified
extendedtank Modified
flare Modified
flashbang Modified
forensic Modified
france Modified
glasses Modified
handcuff Modified
headset Modified
heart Modified
holo Modified
implant Modified
inflatable Modified
internals Modified
latex Modified
light Modified
lightmixed Modified
lighttube Modified
magazine Modified
meson Modified
mousetraps Modified
nitrile Modified
nitrogentank Modified
omegacart Modified
pda Modified
pillbox Modified
sechud Modified
shelltoy Modified
solution_trays Modified
sterile Modified
swab Modified
syringe Modified
throwing_knives Modified
trashbag Modified
vials Modified
writing Modified
writing_of_doom Modified
ziptie Modified
box_id Removed
box_olive Removed
shellbeanbag Removed
shellflare Removed
shellflash Removed
shellincendiary Removed
shelllethal Removed
shellpractice Removed
shellslug Removed
shelltranquilizer Removed
shelluranium Removed

Resources/Textures/Objects/Storage/boxicons.rsi

State Old New Status
beaker Modified
bodybags Modified
box Modified
box_of_doom Modified
circuit Modified
disk_kit Modified
donk_kit Modified
flashbang Modified
glasses Modified
handcuff Modified
implant Modified
latex Modified
light Modified
lightmixed Modified
lighttube Modified
meson Modified
mousetraps Modified
pda Modified
pillbox Modified
sechud Modified
solution_trays Modified
sterile Modified
syringe Modified
throwing_knives Modified
tracks Modified
vials Modified
ziptie Modified

Resources/Textures/Objects/Storage/medalcase.rsi

State Old New Status
closed Modified
open Modified

Resources/Textures/Objects/Tools/Cowtools/cow_toolbox.rsi

State Old New Status
icon Modified
icon-open Removed

Resources/Textures/Objects/Tools/Decoys/agent_decoy.rsi

State Old New Status
folded Modified

Resources/Textures/Objects/Tools/Decoys/commander_decoy.rsi

State Old New Status
folded Modified

Resources/Textures/Objects/Tools/Decoys/elite_decoy.rsi

State Old New Status
folded Modified

Resources/Textures/Objects/Tools/Decoys/juggernaut_decoy.rsi

State Old New Status
folded Modified

Resources/Textures/Objects/Tools/Decoys/operative_decoy.rsi

State Old New Status
folded Modified

Resources/Textures/Objects/Weapons/Guns/Ammunition/Boxes/anti_materiel.rsi

State Old New Status
base Modified
mag-1 Modified
mag-2 Modified
mag-3 Modified
base-b Removed
magb-1 Removed
magb-2 Removed
magb-3 Removed

Resources/Textures/Objects/Weapons/Guns/Ammunition/Boxes/caseless_rifle.rsi

State Old New Status
base Modified
mag-1 Modified
mag-2 Modified
mag-3 Modified
base-10x24 Removed
base-b Removed
mag10-1 Removed
mag10-2 Removed
mag10-3 Removed
magb-1 Removed

Resources/Textures/Objects/Storage/donkpocket.rsi

State Old New Status
icon Removed
inhand-left Removed
inhand-right Removed

Edit: diff updated after 5ca3603

@Emisse
Copy link
Contributor

Emisse commented Jan 8, 2025

art approval

@lzk228
Copy link
Contributor

lzk228 commented Jan 8, 2025

wait, aren't we against cabinet and for 3/4?

@Emisse
Copy link
Contributor

Emisse commented Jan 8, 2025

cabinet for items

@lzk228
Copy link
Contributor

lzk228 commented Jan 8, 2025

got it

@ps3moira
Copy link
Contributor Author

ps3moira commented Jan 8, 2025

wait, aren't we against cabinet and for 3/4?

Structures for the most part will stay 3/4ths. Items and interactable will be cabinety :trollface:

@beck-thompson beck-thompson added P3: Standard Priority: Default priority for repository items. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. A: Art Area: Art with no implications for other areas. T: Visual Change Type: Deals with changes to art, sprites or other visuals in the game. labels Jan 8, 2025
@github-actions github-actions bot added size/S Denotes a PR that changes 10-99 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Jan 9, 2025
@ps3moira ps3moira marked this pull request as draft January 27, 2025 05:55
@ps3moira ps3moira marked this pull request as ready for review January 28, 2025 01:35
@ps3moira ps3moira marked this pull request as draft January 29, 2025 06:05
@ps3moira ps3moira marked this pull request as ready for review February 2, 2025 17:22
@Djungelskog2
Copy link

really not a fan of the toolbox sprites, they looks like a massive downgrade

@ps3moira ps3moira mentioned this pull request Feb 4, 2025
@K-Dynamic
Copy link
Contributor

K-Dynamic commented Feb 4, 2025

really not a fan of the toolbox sprites, they looks like a massive downgrade

Downgrade and cabinet perspective is intentional as art directors expressed a desire to return to modernised r4407 art style, as opposed to the current mishmash of styles from Eris and tg/goon

@Emisse Emisse merged commit b2a6d5c into space-wizards:master Feb 4, 2025
14 checks passed
@Chi-Firka
Copy link

you're stuck in 2010

@EmoGarbage404
Copy link
Contributor

rising out of a deep and restful sleep to gently mark this hallowed pr with the stigmata of cabinetifaction approval. may all your sprites be tilted and your players too

@deltanedas
Copy link
Contributor

goon human but cabinet perspective

lzk228 added a commit to lzk228/space-station-15 that referenced this pull request Feb 20, 2025
lzk228 added a commit to lzk228/space-station-15 that referenced this pull request Feb 20, 2025
@lzk228 lzk228 mentioned this pull request Feb 20, 2025
slarticodefast pushed a commit that referenced this pull request Feb 20, 2025
Killerqu00 added a commit to spess14/trailblazer-colony-14 that referenced this pull request Feb 25, 2025
* move a colon to the localization string (#35192)

* move the colon to the localization string

* remove a redundancy

* beck suggested this per how its done elsewhere.

* comply with requested changes.

* remove usages of obsolete EntityUid method variants (#35106)

eughhhhh

* Update Credits (#35196)

Co-authored-by: PJBot <[email protected]>

* Docking allocs reduc (#34965)

Stuff I had unstaged.

* Update submodule to 245.1.0 (#35198)

Reh

* fix relic

* Update submodule to 245.1.0 (#35198)

Reh

* Add planet lighting (#32522)

* Implements a Dynamic Lighting System on maps.

* Edit: the night should be a little bit brighter and blue now.

* Major edit: everything must be done on the client side now, with certain datafield replicated.
Changes were outlined in the salvage to accommodate the new lighting system.

* Edit: The offset is now serverside, this makes the time accurate in all situations.

* Removing ununsed import

* Minor tweaks

* Tweak in time precision

* Minor tweak + Unused import removed

* Edit: apparently RealTime is better for what I'm looking for

* Fix: Now the time is calculated correctly.

* Minor tweaks

* Adds condition for when the light should be updated

* Add planet lighting

* she

* close-ish

* c

* bittersweat

* Fixes

* Revert "Merge branch '22719' into 2024-09-29-planet-lighting"

This reverts commit 9f2785bb16aee47d794aa3eed8ae15004f97fc35, reversing
changes made to 19649c07a5fb625423e08fc18d91c9cb101daa86.

* Europa and day-night

* weh

* rooves working

* Clean

* Remove Europa

* Fixes

* fix

* Update

* Fix caves

* Update for engine

* Add sun shadows (planet lighting v2)

For now mostly targeting walls and having the shadows change over time. Got the basic proof-of-concept working just needs a hell of a lot of polish.

* Documentation

* a

* Fixes

* Move blur to an overlay

* Slughands

* Fixes

* Remove v2 work

* Finalise

---------

Co-authored-by: DoutorWhite <[email protected]>

* Automatic changelog update

* Update submodule to 246.0.0 (#35202)

* Add ability for admins to change certain cvars via command. (#35105)

* Add ability for admins to change certain cvars via command.

* Cleanup

* More cleanup.

* Even more cleanup.

* WAITER! WAITER! ONE MORE COMMIT PLEASE!

* Remove requirement for Admin AdminFlag

Not needed as the command checks for the perms.

* Add search function to CVars and help text

* Move to controller instead.

* Add another cvar for testing

* Remove unused comment

* Move to Post Server Initialize

LoC does not work at the earlier stages of server initalization

* Remove unneeded comment

We clear out list so its no longer needed

* Update engine to v247.0.0

* Fix merge conflict

* Expand whitelist

* Apply RoofOverlay per-grid not per-map + fix lighting quality (#35207)

* Apply RoofOverlay per-grid not per-map

* Fix light render scales

* Automatic changelog update

* Uncomment blur (#35213)

Was used for debug but stable now.

* Automatic changelog update

* Ignore weather on rooved tiles (#35214)

Might want more flexibility in future but weather needs some polish and this is fine for now.

* Automatic changelog update

* Fix hitscan visuals (#34515)

* Fix hitscan visuals

* remove unnecessary changes

* rename `mapDirection`

* Automatic changelog update

* fix sync issue with paramed siren (#35203)

fix sync issue with paramed siren

Co-authored-by: ElectroJr <[email protected]>

* Automatic changelog update

* fix use in hand for uplink items (#35218)

* Automatic changelog update

* Change `visualize` command perms to VarEdit instead of Admin (#35221)

People with VarEdit can use VV but can't use visualize, makes no sense. 

Has headmin approval here: https://canary.discord.com/channels/310555209753690112/1193403928096821358/1340756276371787827

* Wizard Fix - Summon Ghost Event no longer shows Admin Ghosts or Revenants (#34994)

* Prevents admin ghosts from being shown with ghost event

* Changes summon ghost tooltip to permanently visible

* Adds AllowGhostShownByEvent tag, adds it to regular observers, removes ghost hands check & revenant check and replaces it with a tag check.

* Update ContentLocalizationManager.cs

* I'm gonna do something drastic I swear.

* [ADMIN] Adds missing accesses to universal access config (#35229)

init

* Automatic changelog update

* Replaced Bulldog beanbag drum with lethals drum (#34945)

* Replaced Bulldog beanbag drum with lethals drum

* Update Resources/Locale/en-US/store/uplink-catalog.ftl

Co-authored-by: ArtisticRoomba <[email protected]>

* Update duffelbag.yml bulldog bundle description.

---------

Co-authored-by: ArtisticRoomba <[email protected]>

* Automatic changelog update

* Fix debug assert in ScoopableSolution (#35225)

* Fix debug assert in ScoopableSolution

* Don't stomp the old Handled value

* Update ContentLocalizationManager.cs

* ConfirmableAction for DNA Scrambler implant (#35232)

* Automatic changelog update

* made requested changes.

* General storage fixes (#34845)

* Fix storage stars

* Fix some more storage bugs

- Fix positions not saving.
- Fix the 1-tick delay between parent and child storage UIs opening / closing.
- Fix BackButton being visible sometimes when it shouldn't be.

* milon is a furry

* Don't count lobby players for latejoin antag ratio (#35209)

pass playercount to midround antag calculation

* Centcomm 3: Beyond Thunderdome (#35240)

centcomm update

* Automatic changelog update

* centcomm fix (#35244)

* init

* slightly lighter

* i cant decide

* Re-implement world gen (space debris) across all servers (#34795)

* Re-implement world gen (space debris) across all servers

* Move server-specific worldgen config change to base config

---------

Co-authored-by: Simon <[email protected]>

* Automatic changelog update

* Centcomm 3: Beyond Thunderdome Update (#35251)

* centcomm update

* eef freef

* blue

* New Feature: Votekick bans distinguish themselves as votekicks (#35258)

* Feature

* Localization

* Automatic changelog update

* Fix SuperSlippery And StepTriggers persisting when UpdateSlip is called (#34525)

* Fix superSlippery and stepTrigger values persist

- made values in SpillTileReaction's public so we can query the
prototype

- made the default values for slippery component and
StepTriggerComponent based on default constants
for easier resetting

- added a calculation and check in UpdateSlips to check
if a super slip is present as well as Update
relevant steptrigger and slip values based on the contents of the
solution

* The worlds biggest change

---------

Co-authored-by: Myra <[email protected]>

* Automatic changelog update

* Make AllowedEmotes bypass whitelists and fix syndiborg ability to laugh (#31510)

* Automatic changelog update

* Magical contraband type (#35254)

* init

* really ponderous

* Minor station AI code cleanup (#34476)

* Add ability for +VVEDIT users to scale damage/healing in the game (#35255)

* Initial commit

* Add universal modifier for all damage/heals, make guidebooks work.

* help text

* Automatic changelog update

* Automatic changelog update

* [ChangeCVarCommand] Mapping Command (#35239)

[ChangeCVarCommand] MappingCommand

* Automatic changelog update

* [Bugfix] ContrabandSystem checks jobs correctly (#35228)

* make it work lol

* index protos only once

* Automatic changelog update

* Fix MappingCommand grid loading (#35233)

* UseInHandEvent cleanup (#35231)

* fix observer ghost spawn error (#35253)

* Added a test for the MagazineVisualsComponent and fixed found issues (#34491)

* Automatic changelog update

* Fix build ghosts not being placeable on a new round. (#35097)

* Small loadout window improvement (#35171)

Co-authored-by: Tayrtahn <[email protected]>
Co-authored-by: ArtisticRoomba <[email protected]>

* Make ``ShuttleGunBase`` child of ``BaseStructure`` (#35085)

* Remove unnecessary prototype reloading in integration tests (#35199)

* Add radiation shielding to metal crates (#35168)

* Automatic changelog update

* Remove inaccessible code from SharedDoAfterSystem (#35089)

* Fix contraband parenting defaulting to security. (#35281)

Fix an issue with contraband parenting that made janitor restricted gear available to security.

* Automatic changelog update

* Crusher Dagger Knife Component (#35259)

* Added Knife Component to Crusher dagger, allowing
it to be used in a few new crafting recipes such
as baseball bats.

* Changed BaseKnife to CombatKnife, reordered parents

* now inherits from baseknife, throwing and disarm added manually

* Automatic changelog update

* add ShowJobIcons to AiHeldIntellicard (#35282)

so crew is still crew when you are icard

* Automatic changelog update

* Wizard Recall shows Disappearing text at Coordinate (#35272)

* Add prediction for coordinate based popups

* Remove use of deprecated EntityCoordinates.ToMap

* RecallItem displays disppearing text at entity coordinates

* Update Content.Shared/ItemRecall/SharedItemRecallSystem.cs

Co-authored-by: slarticodefast <[email protected]>

* Update Content.Shared/Popups/SharedPopupSystem.cs

Co-authored-by: slarticodefast <[email protected]>

* Add ItemRecall message for witnesses

* Update Content.Shared/ItemRecall/SharedItemRecallSystem.cs

Co-authored-by: slarticodefast <[email protected]>

* Update Resources/Locale/en-US/item-recall/item-recall.ftl

Co-authored-by: slarticodefast <[email protected]>

* Fix namespace issues

* Fix Loc string

* Dont fixstuff tired..

* Prefix THE

* Filter around the entity, and remove recipient if needed

* Alphabetical imports

* Update Content.Client/Popups/PopupSystem.cs

Co-authored-by: slarticodefast <[email protected]>

* fixup

* Better handling.

---------

Co-authored-by: Cooper Wallace <[email protected]>
Co-authored-by: slarticodefast <[email protected]>

* Automatic changelog update

* loop latejoin hotfix (#35260)

latejoin

* centcomm update (#35293)

* Fix some emotes not respecting pronounces (#35289)

* guys let's not allow those things

* fix those too

* Saxophone fix (#35257)

Saxophone-Fix

* Automatic changelog update

* Make CharacterPickerButton the same height for dwarves as for non-dwarves (#35297)

Character picker button height equality for dwarves

* Returns Explosive Technology recipes to Protolathes (#35303)

add scienceexplosives to dynamic pack

* Automatic changelog update

* Make OuterClothing hide PDA and belt sprites under it. (#33448)

Make OuterClothing hide the PDA sprite

* Automatic changelog update

* Fixing intercom encryption key dropping (#34582)

* Added optional param to PickupOrDrop to allow the item to be moved next to the owner of the hand component

* cleanup placement code

* Automatic changelog update

* Fix ExaminableHunger spelling (#35309)

Fix ExaminableHunger spelling mistake

* ports two barsigns from frontier (#35296)

* adds two new barsigns

* webedit to fix a typo

* the typo was in two locations

* reformatted meta.json and added attribution links

* Automatic changelog update

* Space Lizard Plushie In-hands (#35295)

* space lizard

* attributions

* attribution fix

* Removed Contraband Status from Flares (#34705)

* Update shotgun.yml

* Update shotgun.yml

* Update shotgun.yml

* Automatic changelog update

* Fix: Toys sounds (#33449)

Co-authored-by: Winkarst <[email protected]>
Co-authored-by: slarticodefast <[email protected]>

* Automatic changelog update

* Update engine to v247.1.0 (#35324)

* Added a component that lets ranged weapons make melee attacks. (#29484)

* General storage fixes (#34845)

* Fix storage stars

* Fix some more storage bugs

- Fix positions not saving.
- Fix the 1-tick delay between parent and child storage UIs opening / closing.
- Fix BackButton being visible sometimes when it shouldn't be.

* milon is a furry

* Fix missing errorOnMissing arg being passed thru (#35328)

* Replace obsolete FromMap calls with ToCoordinates (#35304)

* Purge uses of TransformComponent.Anchored.set. Also adds parentheses. (#34938)

* Revert "Purge uses of TransformComponent.Anchored.set. Also adds parentheses." (#35332)

* Fix to make all corpses butcher able and better disposable (#33727)

* Made all corpses disposable. Argocytes, Mimics, Butterflies, Bees, Space Kangaroos, Laser Raptors and Watchers their corpses can now be butchered.

* Accidentally removed a line break. restored it.

* Removed a dash that did not belong there.

* Changed mimic giving a "Changeling Sting Can" when butchered instead of normal meat.

* Automatic changelog update

* Remove storage hotbar GUI bandaid (#35054)

* Remove storage hotbar GUI bandaid

With BUI deferred opens it also happened to fix this issue which is nice.

* Update Content.Client/Storage/StorageBoundUserInterface.cs

* Automatic changelog update

* Require hwid (#35331)

* Make cvar to require that the client has a modern hwid

* Ignore guests and don't disable cvar on dev

* Rename and add docs

* 2 lines yaml cleanup (#35338)

* fix migration.yml (#35339)

space-wizards/space-station-14#34293

* Mjollnir and Singularity Hammer for Wizard (#34446)

* Fixed Veggie pizza slice having 40u of reagent space (#35343)

* Fixed Veg pizza slice having 40u of reagent space

* Changed FoodPizzaVegetableSlice to hold 10u rather than 6u

* Fixed donk pocket slice having 50u reagent space.

* fix rubber hammer attack rotation (#35357)

* Adds Colored Light Bulbs (#35333)

* goober

* changes parenting

* Automatic changelog update

* make the detailed examine verb predicted (#35362)

can we stop predicting things

* Fix prying shut unpowered doors (#35380)

* Fix sink draining sound (#34173)

* Automatic changelog update

* Minor SpriteFade stuff (#35385)

* Wizard: Repulse Spell (#35377)

* Comment out broken guidebook test speech code (#35398)

This code blatantly doesn't work and causes compile failures with space-wizards/RobustToolbox#5540. It's only used for testing purposes, so we're just removing it.

Basically taken from space-wizards/space-station-14#33610 in another PR, so I can merge this first separately.

* New Feature: Admin Only messages in AHelp (#35283)

* Feature

* Update

* Update

* Update

* Update Resources/Locale/en-US/administration/bwoink.ftl

Co-authored-by: Pieter-Jan Briers <[email protected]>

* Yes

---------

Co-authored-by: Pieter-Jan Briers <[email protected]>

* Automatic changelog update

* Give dogs speech noises (#35383)

* Automatic changelog update

* Wizard: Smoke Spell (#35403)

* Adds smoke spell for wizard

* Adds the actual sprites oops

* Removes repulse attract change

* Removes change again?

* Update Credits (#35410)

Co-authored-by: PJBot <[email protected]>

* [HOTFIX] Borg emag notification and sound fix (#35394)

epic stuff

* [HOTFIX] Altered Silicon removal fails to trigger role update (#35399)

minor sharedrolesystem refactor

* Fixed Guidebook Sorting / Ordering (#34960)

* fixed all yml and cs

* Subjective Rearranging

* fixed my accidentally removed xml endline

* Accidentally included for a different PR

* Added .ThenBy and cleaned up newplayer.yml

* Automatic changelog update

* make opening storage on verb or on interact not silent (#35413)

* make storage make sound

* remove

Co-authored-by: Winkarst <[email protected]>

---------

Co-authored-by: Winkarst <[email protected]>

* Automatic changelog update

* Roof data rework (#35388)

* Amber Station Improvements (#35384)

* Redid TEG, minor fixes around

* Ran fixgridatmos, variantize, fixrotations, tileswalls

* Elkridge Science 2.0 + misc fixes (#35392)

* added radationblockercontainer component to pacman fuel crate so it doesnt leak rads, also more rad suits

* reworked science, misc fixes and changes

* Update submodule (#35411)

* Lattice tiles footsteps now sound like catwalks (#35421)

change lattice from FootstepPlating to FootstepCatwalk

* Automatic changelog update

* Refactor audio system to send collection IDs over the network (#33610)

* Fix window positions not saving (#35055)

Co-authored-by: Kevin Zheng <[email protected]>

* Automatic changelog update

* Swap price of EMAG and AD. (#35354)

init

* Automatic changelog update

* Sentry turrets - Part 2: Basic prototype (#35031)

* Add interaction tests for prying airlocks (#35409)

* Sentry review (#35424)

Co-authored-by: chromiumboy <[email protected]>
Co-authored-by: chromiumboy <[email protected]>

* Remove disablers from emagged lathe (#35423)

* Add microwave recipes to the guidebook (#34105)

* Automatic changelog update

* Fix/Addition - Wizard Survivor Antag Status (#35226)

* Use new engine APIs for setting the scroll target of views (#35401)

* Add a tertiary header parser to the guidebook document parser (#35315)

* Automatic changelog update

* version watermark (#35284)

* version watermark

* force version watermarks on vulture

* Automatic changelog update

* fix chameleon projector ripley bug (#35070)

Co-authored-by: deltanedas <@deltanedas:kde.org>

* Automatic changelog update

* Make holoparasite's damage transfer ignore the host's armor (#35418)

Change stuff

* Automatic changelog update

* Fix: Admin-only messages still show "(S)" on Discord (#35431)

Fix

* Cleanup: Use ``SoundSpecifier`` instead of string literals in ``VomitSystem`` (#35426)

* Cleanup

* Update

* Update

* Put Neckwear above Backpacks (#35322)

Puts Neck layer on top of Back.

* Automatic changelog update

* Fix prototypes so they pass analyzer checks (#35435)

* Fix bogus AdminNameOverlay Rider error (#35432)

* Fix admin test arena (#35444)

* Fix admin test arena

* Add to GridsLoadableTest

* QueueDel map, remove nullable

---------

Co-authored-by: ElectroJr <[email protected]>

* Fix arrivals (#35439)

* Automatic changelog update

* Cleanup: Use ``SoundSpecifier`` instead of string literals in ``EyeClosingComponent`` (#35425)

* Cleanup

* Update

* Update

* Update

* GettingUsedAttemptEvent (#35450)

* init

* review

* doc

* Update Content.Shared/Interaction/Events/GettingUsedAttemptEvent.cs

---------

Co-authored-by: slarticodefast <[email protected]>

* Move FingerprintComponent and FingerprintMaskComponent to shared (#35451)

* init

* review

* whoopsie

* Cleanup: Pass in ``IComponentFactory`` in ``EntityPrototype.TryGetComponent`` calls inside ``ChemistryGuideDataSystem`` (#35456)

* Cleanup

* Update

* Cleanup: Pass in ``IComponentFactory`` in ``EntityPrototype.TryGetComponent`` calls inside ``FlatpackSystem`` (#35457)

* Cleanup

* Update

* Cleanup: Pass in ``IComponentFactory`` in ``EntityPrototype.TryGetComponent`` calls inside ``MaterialStorageSystem`` (#35458)

* Cleanup

* Update

* Cleanup: Pass in ``IComponentFactory`` in ``EntityPrototype.TryGetComponent`` calls inside ``EventManagerSystem`` (#35460)

Cleanup

* Cleanup: Fix field naming rule violation in ``GhostComponent`` (#35454)

* Fix

* Update Content.Shared/Ghost/GhostComponent.cs

---------

Co-authored-by: slarticodefast <[email protected]>

* Cleanup: Pass in ``IComponentFactory`` in ``EntityPrototype.TryGetComponent`` calls inside ``ImmovableRodRule`` (#35462)

Cleanup

* Cleanup: Pass in ``IComponentFactory`` in ``EntityPrototype.TryGetComponent`` calls inside ``SharedMaterialStorageSystem`` (#35463)

Cleanup

* Cleanup: Pass in ``IComponentFactory`` in ``EntityPrototype.TryGetComponent`` calls inside ``SharedStackSystem`` (#35464)

Cleanup

* TryGetRandomRecord in StationRecordsSystem (#35452)

* init

* requested changes

* stuff

* Cleanup: Remove redundant checks from ``SharedWieldableSystem`` (#35466)

Cleanup

* Cleanup: Pass in ``IComponentFactory`` in ``EntityPrototype.TryGetComponent`` calls inside ``SharedChameleonProjectorSystem`` (#35465)

* Cleanup

* Yes

* Cleanup: Use ``MapSystem.DeleteMap`` instead of ``IMapManager.DeleteMap`` in ``CargoTest`` (#35467)

* Cleanup

* Update

* Fix

* Cleanup: Use ``MapSystem.DeleteMap`` instead of ``IMapManager.DeleteMap`` in ``HandTests`` (#35468)

* Cleanup

* Update

* Fix

* Cleanup: Use ``MapSystem.DeleteMap`` instead of ``IMapManager.DeleteMap`` in ``HumanInventoryUniformSlotsTest`` (#35469)

* Cleanup

* Fix

* Cleanup: Use ``MapSystem.DeleteMap`` instead of ``IMapManager.DeleteMap`` in ``InteractionTest`` (#35470)

Cleanup

* Cleanup: Use ``MapSystem.DeleteMap`` instead of ``IMapManager.DeleteMap`` in ``MaterialArbitrageTest`` (#35471)

Cleanup

* Cleanup: Use ``MapSystem.DeleteMap`` instead of ``IMapManager.DeleteMap`` in ``MaterialPrototypeSpawnsStackMaterialTest`` (#35472)

* Cleanup

* Fix

* Cleanup: Use ``MapSystem.DeleteMap`` instead of ``IMapManager.DeleteMap`` in ``MindTests`` (#35473)

* Cleanup

* Fix

* Cleanup: Use ``MapSystem.DeleteMap`` instead of ``IMapManager.DeleteMap`` in ``StartingGearPrototypeStorageTest`` (#35474)

* Cleanup

* Fix

* Cleanup: Use ``MapSystem.DeleteMap`` instead of ``IMapManager.DeleteMap`` in ``SalvageSystem.Magnet`` (#35475)

Cleanup

* Cleanup: Use ``SoundCollectionSpecifier`` instead of string literals in ``PowerGridCheckRule`` (#35449)

* Cleanup

* Update

* .

* Volume

* Cleanup: Use ``SoundCollectionSpecifier`` instead of string literals in ``BibleSystem`` (#35448)

* Cleanup

* Update

* [ADMIN minor update] Add Autocompletion for Player Usernames in SetMind Command (#35477)

* add(src): Add getCompletion player for setmind command

* tweak(src): Fulfilling review requirements. used CompletionHelper.SessionNames()

* tweak(loc): Add localization

* fix(srs): smail

* Automatic changelog update

* Custom arrivals shuttle for Relic (#35194)

* Custom arrivals shuttle for Relic.

* Added shuttle APU

* Saved it as a grid the way I now see the mapping guide said I was supposed to do it

* Relic arrivals hallway more historically accurate.

* Removed invalid configurator

* Automatic changelog update

* fix ion storm code readability (#35337)

fix ion storm readability

* Cleanup: Make ``EyeCursorOffsetSystem`` sealed (#35481)

Cleanup

* Make the version watermark less annoying (#35484)

* make version watermark less annoying

* skreee

* Automatic changelog update

* Cleanup: Fix formatting in ``CCVars.Game`` (#35483)

Cleanup

* fix mousetraps (#35486)

fix mousetrap

* Automatic changelog update

* borgs don't scream (#33038)

* borgs don't scream

* revert that

* Automatic changelog update

* [ADMIN] Admin IDs now have Agent ID properties (#35345)

init

* Automatic changelog update

* Unbreakable bar sign fix. (#35490)

* Fixed bar signs being indestructable

* Apply suggestions from code review

---------

Co-authored-by: slarticodefast <[email protected]>

* Automatic changelog update

* Adds new speech bubble opacity sliders to the accessibility menu. (#35346)

* Adds new accessibility slider for speech bubble text opacity.
Adds new accessibility slider for speech bubble background opacity.
Adds new Cvars to track speech bubble text and background opacity settings.

* Adds a separate option slider for the opacity of the speaker's name on speech bubbles.

* Changes text and speaker default opacity to 100%, as it was before.

* Apply suggestions from code review

---------

Co-authored-by: slarticodefast <[email protected]>

* Automatic changelog update

* Make escape key work as expected with multiple open inventories (#35040)

* Automatic changelog update

* Add species-specific code for ToggleableLightVisuals (#35482)

* WHY DO THE FUCKING GAY SCARFS KEEP BREAKING

* ugh

* robust skill issue?

* whaur

---------

Co-authored-by: Kyle Tyo <[email protected]>
Co-authored-by: Milon <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: PJBot <[email protected]>
Co-authored-by: metalgearsloth <[email protected]>
Co-authored-by: ElectroJr <[email protected]>
Co-authored-by: DoutorWhite <[email protected]>
Co-authored-by: Simon <[email protected]>
Co-authored-by: Leon Friedrich <[email protected]>
Co-authored-by: Vasilis The Pikachu <[email protected]>
Co-authored-by: Velken <[email protected]>
Co-authored-by: slarticodefast <[email protected]>
Co-authored-by: keronshb <[email protected]>
Co-authored-by: Kyle Tyo <[email protected]>
Co-authored-by: ScarKy0 <[email protected]>
Co-authored-by: PicklOH <[email protected]>
Co-authored-by: ArtisticRoomba <[email protected]>
Co-authored-by: Tayrtahn <[email protected]>
Co-authored-by: psykana <[email protected]>
Co-authored-by: Errant <[email protected]>
Co-authored-by: Emisse <[email protected]>
Co-authored-by: ScarKy0 <[email protected]>
Co-authored-by: Sparlight <[email protected]>
Co-authored-by: Winkarst <[email protected]>
Co-authored-by: Zachary Higgs <[email protected]>
Co-authored-by: Myra <[email protected]>
Co-authored-by: lzk <[email protected]>
Co-authored-by: chromiumboy <[email protected]>
Co-authored-by: SlamBamActionman <[email protected]>
Co-authored-by: Ignaz "Ian" Kraft <[email protected]>
Co-authored-by: War Pigeon <[email protected]>
Co-authored-by: BramvanZijp <[email protected]>
Co-authored-by: Pronana <[email protected]>
Co-authored-by: lizelive <[email protected]>
Co-authored-by: Cooper Wallace <[email protected]>
Co-authored-by: Cooper Wallace <[email protected]>
Co-authored-by: TytosB <[email protected]>
Co-authored-by: SpaceLizard <[email protected]>
Co-authored-by: Absotively <[email protected]>
Co-authored-by: K-Dynamic <[email protected]>
Co-authored-by: Booblesnoot42 <[email protected]>
Co-authored-by: MilenVolf <[email protected]>
Co-authored-by: robinthedragon <[email protected]>
Co-authored-by: SeamLesss <[email protected]>
Co-authored-by: FungiFellow <[email protected]>
Co-authored-by: Winkarst <[email protected]>
Co-authored-by: Sigil <[email protected]>
Co-authored-by: TemporalOroboros <[email protected]>
Co-authored-by: Zokkie <[email protected]>
Co-authored-by: nikthechampiongr <[email protected]>
Co-authored-by: spderman3333 <[email protected]>
Co-authored-by: Boaz1111 <[email protected]>
Co-authored-by: Pieter-Jan Briers <[email protected]>
Co-authored-by: themias <[email protected]>
Co-authored-by: Pieter-Jan Briers <[email protected]>
Co-authored-by: GrownSamoyedDog <[email protected]>
Co-authored-by: Southbridge <[email protected]>
Co-authored-by: Deerstop <[email protected]>
Co-authored-by: pathetic meowmeow <[email protected]>
Co-authored-by: Kevin Zheng <[email protected]>
Co-authored-by: chromiumboy <[email protected]>
Co-authored-by: deltanedas <[email protected]>
Co-authored-by: No Elka <[email protected]>
Co-authored-by: Tiniest Shark <[email protected]>
Co-authored-by: Schrödinger <[email protected]>
Co-authored-by: Vortebo <[email protected]>
Co-authored-by: Theodore Lukin <[email protected]>
Co-authored-by: noirogen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Art Area: Art with no implications for other areas. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P3: Standard Priority: Default priority for repository items. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. size/M Denotes a PR that changes 100-999 lines. T: Visual Change Type: Deals with changes to art, sprites or other visuals in the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants