Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotbar actions are still bugged #26142

Closed
thebadman4662 opened this issue Mar 15, 2024 · 16 comments · Fixed by #26356 or Simple-Station/Einstein-Engines#365
Closed

Hotbar actions are still bugged #26142

thebadman4662 opened this issue Mar 15, 2024 · 16 comments · Fixed by #26356 or Simple-Station/Einstein-Engines#365
Labels
Issue: Replicated This issue has been replicated by another user. T: Bugfix Type: Bugs and/or bugfixes

Comments

@thebadman4662
Copy link

thebadman4662 commented Mar 15, 2024

Description

Hotbar action with no cooldown trigger twice, effectively never working like PDA flashlight turning on and off, mask being put off and on, harm mode being turned on and off...

Reproduction

  1. Equip actions on your hotbar
  2. Click them with mouse.

Screenshots
https://youtu.be/S0lTa1iBq80

@wrexbe wrexbe added T: Bugfix Type: Bugs and/or bugfixes Issue: Needs Replicating This issue needs reproducing, as only one person has reported it. labels Mar 16, 2024
@wrexbe
Copy link
Contributor

wrexbe commented Mar 16, 2024

What did you do to your control shortcuts?

@Errant-4
Copy link
Member

Description

Hotbar action with no cooldown trigger twice, effectively never working like PDA flashlight turning on and off, mask being put off and on, harm mode being turned on and off...

Reproduction

1. Equip actions on your hotbar

2. Click them with mouse.

Screenshots https://youtu.be/S0lTa1iBq80

Can you please check Options/Controls and show what you see in the second column of bound keys

@thebadman4662
Copy link
Author

obraz

@Errant-4
Copy link
Member

Is this the steam version or a branch? Are you up to date? I was not able to repro the issue. Can anyone? Difficult to come to any conclusions without being able to trigger the issue

@thebadman4662
Copy link
Author

Steam version, wizden servers.

@Errant-4
Copy link
Member

As a test, can you press Reset next to "Use", and see if this resolves the issue?

@thebadman4662
Copy link
Author

thebadman4662 commented Mar 16, 2024

It did work...

Which is weird considering I had the bug for months and even had to fully reset keybinds because of recent hotkey bug. Time to see if it works on rebooting.

And yeah, on rebooting its broken again, on reconnect it works fine, just gotta unbind and bind again every session now.

@Errant-4
Copy link
Member

When you reboot, is shift+click bound as the secondary again, and the reset button is active again? I think your keybind file might be corrupted and maybe isn't properly saved. You could rename keybinds.yml to keybinds_backup and let the system generate a new file. If it does not fix your problem you can rename your previous file to keybinds.yml

@thebadman4662
Copy link
Author

thebadman4662 commented Mar 16, 2024

Use bind itself only matters, secondary bind or lack of it on reboot does not have any impact.

Deleting binds file did work.

@wrexbe
Copy link
Contributor

wrexbe commented Mar 16, 2024

If you still have it, or can get it to happen again, can you upload your binding file?

@thebadman4662
Copy link
Author

thebadman4662 commented Mar 16, 2024

And I got the exact same bug again by setting same binds from scratch as last time, previous binds file was deleted so its not any kind of corruption of it.

My hotkeys:
obraz
obraz
obraz

You want file? Here you go:

version: 1
binds:

  • key: NumpadNum1
    function: CameraRotateLeft
  • key: NumpadNum3
    function: CameraRotateRight
  • key: NumpadNum2
    function: CameraReset
  • key: NumpadAdd
    function: ZoomIn
  • key: NumpadSubtract
    function: ZoomOut
  • canFocus: True
    key: MouseLeft
    function: Use
  • canFocus: True
    mod1: Shift
    key: MouseLeft
    function: Use
  • canFocus: True
    priority: -1
    key: MouseRight
    function: UseSecondary
  • canFocus: True
    mod1: Shift
    key: MouseRight
    function: UseSecondary
  • key: Z
    function: ActivateItemInHand
  • mod1: Shift
    key: Z
    function: ActivateItemInHand
  • key: E
    function: ActivateItemInWorld
  • mod1: Shift
    key: E
    function: ActivateItemInWorld
  • mod1: Shift
    key: Q
    function: Drop
  • key: R
    function: ExamineEntity
  • mod1: Shift
    key: R
    function: ExamineEntity
  • key: X
    function: SwapHands
  • mod1: Shift
    key: X
    function: SwapHands
  • canFocus: True
    key: MouseLeft
    function: MoveStoredItem
  • canFocus: True
    mod1: Shift
    key: MouseLeft
    function: MoveStoredItem
  • key: MouseRight
    function: RotateStoredItem
  • canFocus: True
    mod1: Shift
    key: MouseRight
    function: RotateStoredItem
  • mod1: Shift
    key: B
    function: SmartEquipBackpack
  • key: B
    function: SmartEquipBackpack
  • mod1: Shift
    key: C
    function: SmartEquipBelt
  • key: C
    function: SmartEquipBelt
  • key: Q
    function: ThrowItemInHand
  • key: Tab
    function: ReleasePulledObject
  • mod1: Shift
    key: MouseMiddle
    function: Point
  • canFocus: True
    key: MouseMiddle
    function: Point
  • mod1: Control
    key: Tab
    function: CycleChatChannelForward
  • key: Escape
    function: WindowCloseRecent
  • key: Num1
    function: Hotbar1
  • key: Space
    function: Hotbar1
  • key: Num4
    function: Hotbar4
  • key: NumpadNum4
    function: Hotbar4
  • key: Num5
    function: Hotbar5
  • key: NumpadNum5
    function: Hotbar5
  • key: Num6
    function: Hotbar6
  • key: NumpadNum6
    function: Hotbar6
  • key: Num7
    function: Hotbar7
  • key: NumpadNum7
    function: Hotbar7
  • key: Num8
    function: Hotbar8
  • key: NumpadNum8
    function: Hotbar8
  • key: Num9
    function: Hotbar9
  • key: NumpadNum9
    function: Hotbar9
  • key: Num0
    function: Hotbar0
  • key: NumpadNum0
    function: Hotbar0
    leaveEmpty:
  • ResetZoom
  • OpenBelt
  • OpenBackpack
  • OpenGuidebook
  • OpenCraftingMenu
  • OpenCharacterMenu
  • CycleChatChannelBackward
  • OpenInventoryMenu
  • OpenAbilitiesMenu
  • OpenSandboxWindow
  • WindowCloseAll
  • EscapeContext
    ...

@EmoGarbage404
Copy link
Member

Did you turn off/on numlock or smth

@wrexbe
Copy link
Contributor

wrexbe commented Mar 16, 2024

@thebadman4662 Upload the actual file with the attach button (looks like a paper clip). I tried manually setting my keybindings to yours, maybe I messed it up, but I couldn't get it to happen.

  1. What OS are you using, and does your keyboard, mouse, or a program on your computer have any kind of special macro/key things going on?

  2. If you slowly reset the keybindings to default, which keybinding does resetting stop the problem on?

  3. It may be a bad interaction with a different setting, do you have any other settings not the default?

@thebadman4662
Copy link
Author

thebadman4662 commented Mar 17, 2024

@thebadman4662 Upload the actual file with the attach button (looks like a paper clip). I tried manually setting my keybindings to yours, maybe I messed it up, but I couldn't get it to happen.

Guess ill just try text file instead, I did try last time but yami files are not accepted.
keybinds.txt

1. What OS are you using, and does your keyboard, mouse, or a program on your computer have any kind of special macro/key things going on?

Windows 10, no funny bussiness on my hardware.

2. If you slowly reset the keybindings to default, which keybinding does resetting stop the problem on?

Went from bottom, "close recent window" can't be reset.
obraz

Resetting move stored item or rotate stored item allowed me to use hotbar without touching use binds.
obraz

3. It may be a bad interaction with a different setting, do you have any other settings not the default?

I do not think so? Other than hotkeys I did not need to change anything except maybe MIDI sound when musicians are giving me ear cancer ever now and then.

@wrexbe wrexbe added Issue: Replicated This issue has been replicated by another user. and removed Issue: Needs Replicating This issue needs reproducing, as only one person has reported it. labels Mar 18, 2024
@wrexbe
Copy link
Contributor

wrexbe commented Mar 18, 2024

Can be reproduced with this yml.
Current theory is some kind of problem with most bindings being priority 0's, and the user binding changing the order they get put into the list, and the new order happens not to work. You need to exit the game and start it again, so it loads the user file, and then the default file. Changing the binding while running, once again reorders the binding, so the problem goes away.
There are other weird things going on, but if the binding order/priority is maintained, maybe we can just pretend I didn't see anything.

version: 1
binds:
- canFocus: True
  key: MouseLeft
  function: MoveStoredItem
- canFocus: True
  key: MouseLeft
  function: Use
leaveEmpty: []
...

Probably going to try to fix this later by making it so editing a binding from the UI doesn't lose the priority, and changing the base bindings to have a priority that is explicit enough not to get broken by user changes.

@thebadman4662
Copy link
Author

Bug still present and even pointing at things requires rebind now.

DangerRevolution pushed a commit to Simple-Station/Einstein-Engines that referenced this issue May 20, 2024
## Mirror of PR #26356: [Store keybind
priority](space-wizards/space-station-14#26356)
from <img src="https://avatars.githubusercontent.com/u/10567778?v=4"
alt="space-wizards" width="22"/>
[space-wizards](https://github.com/space-wizards)/[space-station-14](https://github.com/space-wizards/space-station-14)

###### `f7a1ffd0aab25d70ac185753d596469fc1e87480`

PR opened by <img
src="https://avatars.githubusercontent.com/u/81056464?v=4"
width="16"/><a href="https://github.com/wrexbe"> wrexbe</a> at
2024-03-23 02:49:07 UTC

---

PR changed 2 files with 2 additions and 1 deletions.

The PR had the following labels:
- Changes: UI


---

<details open="true"><summary><h1>Original Body</h1></summary>

> Changed it so the priority isn't lost when you set a binding in the
UI.
> Also added a priority to MoveStoredItem so it doesn't conflict with
Use.
> Fixes space-wizards/space-station-14#26142
> Does not fix old keybinds files, so they will need to reset it, and
rebind it.
> 
> A better solution might be to change it so the keybinds are always in
the order they appear in the default keybinds folder, to prevent the
ordering from changing unpredictably based on what the user overrides.


</details>

Co-authored-by: SimpleStation14 <Unknown>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Replicated This issue has been replicated by another user. T: Bugfix Type: Bugs and/or bugfixes
Projects
None yet
4 participants