Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mirror: Store keybind priority #365

Merged
merged 1 commit into from
May 20, 2024
Merged

Mirror: Store keybind priority #365

merged 1 commit into from
May 20, 2024

Conversation

SimpleStation14
Copy link
Member

Mirror of PR #26356: Store keybind priority from space-wizards space-wizards/space-station-14

f7a1ffd0aab25d70ac185753d596469fc1e87480

PR opened by wrexbe at 2024-03-23 02:49:07 UTC

PR changed 2 files with 2 additions and 1 deletions.

The PR had the following labels:

  • Changes: UI

Original Body

Changed it so the priority isn't lost when you set a binding in the UI.
Also added a priority to MoveStoredItem so it doesn't conflict with Use.
Fixes space-wizards/space-station-14#26142
Does not fix old keybinds files, so they will need to reset it, and rebind it.

A better solution might be to change it so the keybinds are always in the order they appear in the default keybinds folder, to prevent the ordering from changing unpredictably based on what the user overrides.

@SimpleStation14 SimpleStation14 added the Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot label May 3, 2024
@VMSolidus VMSolidus marked this pull request as ready for review May 5, 2024 19:26
FoxxoTrystan
FoxxoTrystan reviewed May 13, 2024
View reviewed changes
Copy link
Contributor

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DangerRevolution DangerRevolution merged commit eb7a089 into Simple-Station:master May 20, 2024
20 checks passed
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Dec 15, 2024
@Fansana
Merge pull request Simple-Station#365 from Fansana/voicemask-fix-agai…
0efd87f 
…n-fucking-why

does nobody read the code they PR? the fuck is this?
Mnemotechnician pushed a commit to Mnemotechnician/Einstein-Engines that referenced this pull request Dec 15, 2024
@Floof-Station-Bot
Automatic Changelog Update (Simple-Station#365)
2b17689
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoxxoTrystan FoxxoTrystan FoxxoTrystan left review comments

@VMSolidus VMSolidus VMSolidus approved these changes

@DangerRevolution DangerRevolution DangerRevolution approved these changes

Assignees
No one assigned
Labels
Pull Request Mirror Mirrors a PR from another Repo. Automatically applied by mirror bot
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hotbar actions are still bugged
4 participants
@SimpleStation14 @VMSolidus @FoxxoTrystan @DangerRevolution