Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GA to push image to Docker Hub only on tags (#93). #133

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

ivanperez-keera
Copy link
Contributor

This commit disables pushes of the spaceros docker image up to Docker Hub on the main branch, and it enables pushes on tags. It also enables manually triggering the build job.

This will help ensure that only stable version are pushed to Docker Hub.

@ivanperez-keera ivanperez-keera marked this pull request as ready for review February 1, 2024 03:45
@ivanperez-keera ivanperez-keera force-pushed the dev-workflow-push branch 2 times, most recently from f62d286 to 34585e2 Compare February 1, 2024 03:49
This commit disables pushes of the spaceros docker image up to Docker Hub on
the main branch, and it enables pushes on tags. It also enables manually
triggering the build job.

This will help ensure that only stable version are pushed to Docker Hub.
Copy link
Contributor

@Bckempa Bckempa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is inline with the branch plan that was discussed at the last meeting and obviously will lead to some follow-up work to enable a separate rolling tag.

@ivanperez-keera ivanperez-keera merged commit e4c2027 into main Feb 1, 2024
4 checks passed
@ivanperez-keera ivanperez-keera deleted the dev-workflow-push branch February 1, 2024 10:56
@Bckempa Bckempa added this to the humble-2024.01.0 milestone Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants