Don't push the spaceros image every time we submit a PR

[mkhansenbot]

We currently have one workflow with jobs for Earthly build-and-test and Earthly build-and-push. This means we have to run both together to run a build-and-test. This means we're pushing containers that aren't based on the main branch. I think we should split these into separate workflows. The build-and-test workflow should run on every PR, every merge to main, and nightly. The build-and-push should only run once or twice a day. In fact, I think build-and-push should be build-test-push

[Bckempa]

Related to #91 and #93

[xfiderek]

@mkhansenbot are the names of jobs still up to date? I can't find them. I can only see build-testing-results and space-ros-image in here

[mkhansenbot]

Sorry, I just re-looked at this, I named them wrong in the initial issue, you have the names correct.

The point is still the same, we have one workflow that does both, which means we can't run them separately, which we really should be doing. We don't want to push an image every time there's a PR to this repo. We need to split the action into two.

[ivanperez-keera]

In other repos I've used the branch name to determine whether a push should happen. If the branch is called release-<version_number>, then it's pushed, otherwise it's not. And we could make it such that, when CI job corresponding to a release tag is built, then the same tag is applied in docker hub when the image is uploaded.

[mkhansenbot]

Added to next milestone (proposed) humble-2024.04.0

[mkhansenbot]

Fixed by #133