Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Earthly should ref-spec match Space ROS repos during build #91

Closed
Bckempa opened this issue Nov 2, 2023 · 4 comments · Fixed by #90
Closed

Earthly should ref-spec match Space ROS repos during build #91

Bckempa opened this issue Nov 2, 2023 · 4 comments · Fixed by #90
Assignees
@xfiderek
Milestone
humble-2024.01.0

Comments

@Bckempa
Copy link
Contributor

Bckempa commented Nov 2, 2023

To allow testing of cross-repo changes, the build infrastructure should support matching all space ROS repositories to the current ref-spec (branch or tag) if it exists.

For example, if making a chance on both the space-ros and docker repositories that must be tested together, setting the docker branch to feature/foo should also use the feature/foo branch of space-ros if it exists.
@Bckempa Bckempa added this to the humble-2024.01.0 milestone Dec 3, 2023
@Bckempa Bckempa mentioned this issue Dec 3, 2023
Closed
@Bckempa
Copy link
Contributor Author

Bckempa commented Dec 3, 2023

This isn't strictly necessary for the next milestone but would be very nice to have; but, we can descope if required.

@Bckempa Bckempa mentioned this issue Dec 3, 2023
Closed
@xfiderek
Copy link
Contributor

xfiderek commented Dec 4, 2023

I can take that as it is a bit connected with #88.
Please take a look at that issue.

@Bckempa Bckempa assigned Bckempa and xfiderek and unassigned Bckempa Dec 5, 2023
@ivanperez-keera ivanperez-keera mentioned this issue Dec 14, 2023
Closed
@xfiderek xfiderek mentioned this issue Dec 17, 2023
Closed
@xfiderek
Copy link
Contributor

xfiderek commented Dec 17, 2023 •
edited
Loading

PR is ready: #90
@Bckempa, please transfer this issue to docker repository.

@xfiderek xfiderek mentioned this issue Dec 17, 2023
Merged
@Bckempa Bckempa transferred this issue from space-ros/space-ros Dec 18, 2023
@yuyuqq
Copy link

yuyuqq commented Jan 11, 2024

I was able to build the docker image. Thank you!

Bckempa added a commit that referenced this issue Jan 11, 2024
@Bckempa
Merge pull request #90 from xfiderek/feat/refspec-match
5c0c061 
Add ref-spec matching of spaceros repository (#91).
@github-project-automation github-project-automation bot moved this from In Review to Done in Space ROS Project Development Jan 11, 2024
@Bckempa Bckempa mentioned this issue Jan 13, 2024
Closed
eholum pushed a commit to eholum/space-ros that referenced this issue Jun 26, 2024
@Bckempa
Merge pull request space-ros/docker#90 from xfiderek/feat/refspec-match
74c0eb2 
Add ref-spec matching of spaceros repository (space-ros/docker#91).
eholum pushed a commit to eholum/space-ros that referenced this issue Jun 26, 2024
@Bckempa
Merge pull request space-ros/docker#90 from xfiderek/feat/refspec-match
bd47bd0 
Add ref-spec matching of spaceros repository (space-ros/docker#91).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xfiderek xfiderek

Labels
None yet
Projects
Space ROS Project Development
Status: Done
Milestone
humble-2024.01.0
Development

Successfully merging a pull request may close this issue.

Add ref-spec matching of spaceros repository (#91). xfiderek/spaceros-docker
3 participants
@Bckempa @yuyuqq @xfiderek