This repository has been archived by the owner on Feb 22, 2020. It is now read-only.
Activation refactor #117
Draft
Activation refactor #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efritz
force-pushed
the
activation-refactor
branch
from
5345af5 to
2a6a60e
Compare
efritz
force-pushed
the
activation-refactor
branch
from
2a6a60e to
bd9208b
Compare
efritz
commented
Jan 27, 2020
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "extends": "./node_modules/@sourcegraph/tsconfig/tsconfig.json", | |||
| "compilerOptions": { | |||
| "target": "es2016", | |||
| "target": "es2019", | |||
There was a problem hiding this comment.
We need async generators now.
efritz
commented
Jan 27, 2020
src/lang-go.ts
Outdated
| doc, | ||
| pos, | ||
| sendRequest, | ||
| }: { | ||
| doc: sourcegraph.TextDocument | ||
| pos: sourcegraph.Position | ||
| sendRequest: SendRequest<any> | ||
| }): Observable<lspext.Xreference & { currentDocURI: string }> { | ||
| }): AsyncGenerator<lspext.Xreference & { currentDocURI: string }> { |
There was a problem hiding this comment.
Return async generator instead of observable so we don't have to go from observable -> async generator -> observable later in the code.
efritz
commented
Jan 27, 2020
src/lang-go.ts
Outdated
| definition: () => Promise.resolve(undefined), | ||
| references: () => Promise.resolve(undefined), | ||
| } | ||
| // interface MaybeProviders { |
There was a problem hiding this comment.
Will clean up this and additional dead code in a cleanup PR.
61 tasks
chrismwendt
approved these changes
Jan 28, 2020
There was a problem hiding this comment.
I verified the following behavior remains unchanged:
- With
go.serverUrlset- On a repo missing LSIF
- Hover: LSIF fails, falls back to LSP
- Definition: LSIF fails, falls back to LSP
- References: LSP is used
- On a repo with LSIF
- Hover: LSIF succeeds
- Definition: LSIF succeeds
- References: LSP is used
- On a repo missing LSIF
- With
go.serverUrlnot set: same as Activation refactor code-intel-extensions#198 (review)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the init code after sourcegraph/code-intel-extensions#198.
This removes all LSIF and search-based logic and instead delegates to the
activateCodeIntelfunction, passing it only the language-server specific logic.This PR will be followed by a major cleanup.