This repository has been archived by the owner on Mar 18, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 13
Consolidate code intel extensions #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismwendt
approved these changes
Jan 31, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having everything in one repo is going to make development much nicer ✨
- I updated the README a bit
- I verified
yarn run serve
works
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #198, the interface to activate a code intelligence extension was simplified so that sourcegraph-go and sourcegraph-typescript extensions can use the same LSIF/search fallback logic without duplication. This helps have a central place for logic where changes such as UI badges and telemetry events can happen with lower developer effort and a reduced chance of mistakes.
This action was preluded by this slack thread and by a declaration in this comment on that PR.
This is part one of the consolidation effort. This PR specifically performed the following actions:
extensions/go
extensions/typescript
package/
toshared/
node_modules/.bin
in each template to the same directory in the root (a la sg/sg)yarn run serve
in the extension directory.scripts/
and invocable via yarn commandslanguages.ts
into a packageNext steps will include: