This repository has been archived by the owner on Apr 27, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Feature/mission component] 미션 컴포넌트 제작 #27
[Feature/mission component] 미션 컴포넌트 제작 #27
Changes from all commits
ea20235
3b03a24
afba69b
3d1a74e
36efa93
b468e36
cb4ac30
d6ee197
687b05b
2d66bac
1d4cf82
84bc340
e004630
7af7559
fa45387
fd1a28d
daf5307
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이게 Ui 패키지 내에서 이런 컴포넌트를 제작하는 것에는 동의를 하지만, designsystem 패키지에 있다는 것은 전역에서 사용할 수 있는 컴포넌트를 넣어야 한다고 생각해. 디자인시스템이란 것 자체가 사용자에게 보여지는 뷰에 연관된 것만 정의를 해야지 이걸 도메인과 연관시켜서 구현하는 것은 살짝 오바인 것 같아.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이런식으로 recomposition이 일어나도 isCompleted 값만 바뀔 때 업데이트 할 수 있게 명시적으로 표시해주면 좋을 것 같음