This repository has been archived by the owner on Apr 27, 2023. It is now read-only.
[Feature/mission component] 미션 컴포넌트 제작 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feature/mission-component
feature/mission-component
feature/mission-component
feature/mission-component
feature/mission-component
미션 레벨의 경우 기획에서 의도한 경우가 아닌 경우를 막기 위해 의미를 가지는 미션의 레벨이라는 객체로 래핑하였습니다. feature/mission-component
feature/mission-component
feature/mission-component
feature/mission-component
feature/mission-component
l2hyunwoo
suggested changes
Dec 10, 2022
app/src/main/java/org/sopt/stamp/designsystem/component/button/SoptampIconButton.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/sopt/stamp/designsystem/component/button/SoptampIconButton.kt
Show resolved
Hide resolved
app/src/main/java/org/sopt/stamp/designsystem/component/mission/CompletedStamp.kt
Outdated
Show resolved
Hide resolved
Comment on lines
+12
to
+35
| @Composable | ||
| fun LevelOfMission(stamp: Stamp, spaceSize: Dp) { | ||
| Row( | ||
| horizontalArrangement = Arrangement.spacedBy(spaceSize) | ||
| ) { | ||
| MissionLevelOfStar(stamp = stamp) | ||
| } | ||
| } | ||
|
|
||
| @Composable | ||
| private fun MissionLevelOfStar(stamp: Stamp) { | ||
| repeat(MissionLevel.MAXIMUM_LEVEL) { | ||
| val starColor = if (it <= stamp.missionLevel.value) { | ||
| stamp.starColor | ||
| } else { | ||
| Stamp.defaultStarColor | ||
| } | ||
| Icon( | ||
| painter = painterResource(id = R.drawable.level_star), | ||
| contentDescription = "Star Of Mission Level", | ||
| tint = starColor | ||
| ) | ||
| } | ||
| } |
There was a problem hiding this comment.
이게 Ui 패키지 내에서 이런 컴포넌트를 제작하는 것에는 동의를 하지만, designsystem 패키지에 있다는 것은 전역에서 사용할 수 있는 컴포넌트를 넣어야 한다고 생각해. 디자인시스템이란 것 자체가 사용자에게 보여지는 뷰에 연관된 것만 정의를 해야지 이걸 도메인과 연관시켜서 구현하는 것은 살짝 오바인 것 같아.
Comment on lines
28
to
30
| ) { | ||
| val shape = MissionShape.DefaultWave | ||
| val stamp = Stamp.findStampByLevel(mission.level) |
There was a problem hiding this comment.
Suggested change
| ) { | |
| val shape = MissionShape.DefaultWave | |
| val stamp = Stamp.findStampByLevel(mission.level) | |
| ) { | |
| val (id, title, level, isCompleted, display) = mission | |
| val shape = MissionShape.DefaultWave | |
| val stamp = Stamp.findStampByLevel(level) |
구조분해할당으로 사용하는건 어떰? 어차피 컴포넌트 내에서 사용할 uiState니까 굳이 멤버변수 참조하지말고 분해할당해서 사용하는게 더 편할 것 같음
app/src/main/java/org/sopt/stamp/designsystem/component/mission/CompletedStamp.kt
Show resolved
Hide resolved
app/src/main/java/org/sopt/stamp/designsystem/component/mission/MissionShape.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/sopt/stamp/designsystem/component/mission/Stamp.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/sopt/stamp/designsystem/component/mission/MissionShape.kt
Outdated
Show resolved
Hide resolved
Comment on lines
+12
to
+18
| operator fun invoke(length: Float): MissionPattern { | ||
| return MissionPattern( | ||
| length = length, | ||
| diameter = length * DIAMETER_RATIO, | ||
| gap = length * GAP_RATIO | ||
| ) | ||
| } |
There was a problem hiding this comment.
팩토리를 이렇게도 구현할 수 있다니... 👍🏻 또 배워갑니다.
feature/mission-component
feature/mission-component
feature/mission-component
Shape 의 Count는 프로퍼티로 들어가있으므로 함수에서 전달할 인자가 아니기 때문에 이를 수정하였음. feature/mission-component
feature/mission-component
feature/mission-component
feature/mission-component
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this issue?
공통으로 사용될 미션 컴포넌트 제작입니다.
현우형이 도메인 로직이 얽혀있다는 점을 이야기 해주었는데
초기 설계 의도는 앱 자체 미션 자체가 1~3단계로 구성되어있기 때문에 해당 1,2,3 이란 Int 값은 특별한 의미를 가지는 숫자라고 생각하였습니다.
따라서 미션의 레벨이라는 의미를 가지도록 각 숫자를 래핑 하였으며 1,2,3 이 아닌 숫자가 뷰에 들어간다면 요구 사항에 충족하지 못하는 CASE 라고 생각하여 이를 방지하고자 UI가 외부 파라미터로 도메인 로직을 주입 받게 됩니다.
피드백은 환영입니다
Reference