Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sonata-project/notification-bundle optional #1251

Closed
wants to merge 1 commit into from

Conversation

core23
Copy link
Member

@core23 core23 commented Dec 18, 2020

Subject

I am targeting this branch, because this feature is BC.

Closes #1238

Changelog

### Changed
- Publishing is synchronous by default
- Made `sonata-project/notification-bundle` optional

To do

  • Update the tests;
  • Update the documentation;
  • Add an upgrade note.

@core23 core23 added the minor label Dec 18, 2020
@core23 core23 force-pushed the remove-notification branch 2 times, most recently from 55163fa to 8528c19 Compare December 18, 2020 19:41
@core23 core23 requested a review from a team December 18, 2020 19:42
@core23 core23 force-pushed the remove-notification branch from 8528c19 to eebf6ce Compare December 18, 2020 19:42
@core23 core23 force-pushed the remove-notification branch 2 times, most recently from 51f425b to 75c1011 Compare December 19, 2020 20:05
@core23 core23 force-pushed the remove-notification branch from 75c1011 to 16ddf3a Compare December 19, 2020 20:07
@SonataCI
Copy link
Collaborator

Could you please rebase your PR and fix merge conflicts?

@VincentLanglet
Copy link
Member

Do you plan/have time to finish this @core23 ? :)

@core23
Copy link
Member Author

core23 commented Jun 16, 2021

I lost interest for this bundle. So I haven't time to finish this :(

@github-actions
Copy link

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Dec 13, 2021
@github-actions github-actions bot closed this Dec 20, 2021
@core23 core23 deleted the remove-notification branch December 29, 2021 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove coupling to NotificationBundle
4 participants