Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove coupling to NotificationBundle #1238

Closed
core23 opened this issue Nov 24, 2020 · 2 comments
Closed

Remove coupling to NotificationBundle #1238

core23 opened this issue Nov 24, 2020 · 2 comments
Milestone

Comments

@core23
Copy link
Member

core23 commented Nov 24, 2020

Feature Request

This is the last bundle that relies on the SonataNotificationBundle for no good reason. The original idea was to allow async snapshot creation / cleanup. This can also be done via commands and shouldn't take too long for a normal number of pages.

To allow deprecating the usage, we could introduce a new SnapshotManagerInterface with two methods createSnapshotsForSite and cleanupSnashotsForSite.

WDYT @sonata-project/contributors

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label May 23, 2021
@franmomu franmomu added keep and removed stale labels May 23, 2021
@VincentLanglet VincentLanglet added this to the 4.0 milestone Dec 5, 2021
@VincentLanglet
Copy link
Member

I'll close this in favor of #1415

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants