Remove SonataNotificationBundle from dependencies and code

[eerison]

Remove SonataNotificationBundle

As discussed in #1410 , we need to remove SonataNotificationBundle from the next major release

• Decouple and Deprecate notification bundle from create snapshot code #1418
• Feature/1415/Decouple notification-bundle from cleanup snapshot #1434
• Remove old code related with Commands #1460

Create tickets

• Solve most NEXT_MAJOR comments #1433 Create a ticket to remove all consume code
• after create a new snapshot, it goes for page edit, and should back to the list #1453
• remember to set self deprecation = 0
• Refactor the Cleanup query #1426

[eerison]

I'm on it!

[eerison]

Hey @core23

I didn't see your Issue regarding NotificationBundle #1238 , my bad

#1238 (comment)

But if I understand correct we do not need to use symfony/messager component, or is it necessary?

could you give some example(s) how was you thinking to remove this decency?, I guess you understand this functionality better then me 😄

[eerison]

The original idea was to allow async snapshot creation / cleanup.

do you mean create and remove snapshots from the database?

To allow deprecating the usage, we could introduce a new SnapshotManagerInterface with two methods createSnapshotsForSite and cleanupSnashotsForSite.

do you know where we are managing this logical (to create and remove snapshots) using NotificationBundle? just to have a better understand :)

Edit 1: Hmmm I saw that it was already created SnapshotManagerInterface and SnapshotManager, I'll take a look why we are still using NotificationBundle in the code ;)

[eerison]

Started to deprecate NotificationBundle in #1418

[core23]

But if I understand correct we do not need to use symfony/messager component, or is it necessary?

could you give some example(s) how was you thinking to remove this decency?, I guess you understand this functionality better then me 😄

The idea of my issue was to remove the whole async processing, because a "normal" website should be able to create snapshots on the fly.

The notification bundle or messager component adds a complexity to this bundle that is not necessary.

[eerison]

But if I understand correct we do not need to use symfony/messager component, or is it necessary?
could you give some example(s) how was you thinking to remove this decency?, I guess you understand this functionality better then me 😄

The idea of my issue was to remove the whole async processing, because a "normal" website should be able to create snapshots on the fly.

The notification bundle or messager component adds a complexity to this bundle that is not necessary.

Hey @core23 thank you for reply, make sense to remove this async, because after the project is on production, we usually publish one page when it's needed.

[mareckigit]

I have removed Sonata Notification in my fork: https://github.com/treehousedevelopers/SonataPageBundle/commits/4.x. You can use it with Symfony 5.4 but I'm still working on it.

[eerison]

I have removed Sonata Notification in my fork: https://github.com/treehousedevelopers/SonataPageBundle/commits/4.x. You can use it with Symfony 5.4 but I'm still working on it.

Hi @mareckigit

I didn't find what commit, you are removing the code, But as I can see you are removing this directly from 4.x and we need to create some BC compatibility to the code works in 3.x release!

But we should save our energy to work in different tasks, as I'm working in remove this notification bundle you could work in other task that, as far as I know anyone is working on that, for example: #1096

were you working only in notification bundle or something else? if you worked in other thing could you provide a Pull request with the changes?

Note 1: try to provide small PRs, big PR with a lot of things probably it won't be approved 👀
Note 2: can you comment in the issue before start to code, it'll avoid 2 people work in the same task.
Note 3: it's my PR for removing notification bundle: #1418

[mareckigit]

My goal is to prepare Sonata Page version that will be work with Symfony 5.4. I do my changes in branch 4.x because I expect that is dedicated for Symfony > 4.
My fork includes:

• SF 4+ support #1414;
• Remove SonataNotificationBundle from dependencies and code #1415;
• Remove deprecated usage of ContainerAwareCommand #1422;
• changes in commands;
• fixes for SF 5.4 and Twig 3.

[jordisala1991]

This can be closed, the remaining cleanup does not belong to the usage of SonataNotificationBundle.