refactor(token/cli): extract duplicate config loading logic #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @joncinque , I've remake the PR here. |
|
This looks like a copy of #58 -- can you add the other commits here instead? |
Extract duplicated config loading code into a new `get_cli_config` function to improve code maintainability and reduce duplication. The function handles loading config from file path or default locations.
|
Sorry about that! I mistakenly pushed the wrong code, but I have now pushed the correct code. Please take a moment to review it. |
joncinque
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract duplicated config loading code into a new
get_cli_configfunction to improve code maintainability and reduce duplication. The function handles loading config from file path or default locations.