This repository has been archived by the owner on Jan 10, 2025. It is now read-only.
refactor(token/cli): extract duplicate config loading logic #7638
+15
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract duplicated config loading code into a new `get_cli_config` function to improve code maintainability and reduce duplication. The function handles loading config from file path or default locations. - Move common config loading logic into standalone function - Update new() and new_with_clients_and_ws_url to use shared function - No functional changes
|
@joncinque Can you please review this PR? Thanks |
buffalojoec
approved these changes
Jan 10, 2025
|
Sorry, this repo is about to get archived -- I'll be putting up the official announcement in the repo later today. In the meantime, the token-cli has continued development at https://github.com/solana-program/token-2022/tree/main/clients/cli -- can you remake your PR over there? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract duplicated config loading code into a new
get_cli_configfunction to improve code maintainability and reduce duplication. The function handles loading config from file path or default locations.