chore: apply comments from #27 to existing code in SourceOps.scala
#28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geminicaprograms
force-pushed
the
chore_improvements
branch
2 times, most recently
from
4e3c7f2 to
2a27de1
Compare
geminicaprograms
force-pushed
the
feat_lastOption_last
branch
from
abef2ed to
d60ce81
Compare
geminicaprograms
force-pushed
the
chore_improvements
branch
from
2a27de1 to
2e33ffc
Compare
kciesielski
reviewed
Oct 27, 2023
geminicaprograms
force-pushed
the
feat_lastOption_last
branch
from
d60ce81 to
1200363
Compare
geminicaprograms
force-pushed
the
chore_improvements
branch
from
2e33ffc to
7a1086d
Compare
rucek
reviewed
Oct 27, 2023
| @@ -515,56 +514,58 @@ trait SourceOps[+T] { this: Source[T] => | |||
| } | |||
| c | |||
|
|
|||
| /** Returns the first element from this source wrapped in `Some` or `None` when the source is empty or fails during the receive operation. | |||
| * Note that `headOption` is not an idempotent operation on source as it receives elements from it. | |||
| /** Returns the first element from this source wrapped in [[Some]] or [[None]] when the source is empty. Note that `headOption` is not an | |||
There was a problem hiding this comment.
suggestion: Please see the scaladoc-related comments for last/lastOption:
adamw
approved these changes
Oct 30, 2023
geminicaprograms
force-pushed
the
feat_lastOption_last
branch
from
1200363 to
4f1d858
Compare
geminicaprograms
force-pushed
the
chore_improvements
branch
from
7a1086d to
856823e
Compare
rucek
reviewed
Oct 30, 2023
The `scope` should be only used in internals.
The `ChannelClosed.Error` offers convenient `toThrowable` function. It should be favoured over the new functionality development.
As mentioned in #27.
geminicaprograms
force-pushed
the
chore_improvements
branch
from
856823e to
4c456aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following comments were applied:
supervisedinstead of scopedtoThrowableinstead of ad-hoc exception creation