feat: implement fold operator
#27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geminicaprograms
force-pushed
the
feat_fold
branch
3 times, most recently
from
13f8b50 to
4bef471
Compare
adamw
reviewed
Oct 26, 2023
adamw
reviewed
Oct 26, 2023
This was referenced Oct 27, 2023
geminicaprograms
force-pushed
the
feat_fold
branch
from
4bef471 to
5b42d1b
Compare
geminicaprograms
force-pushed
the
feat_fold
branch
from
5b42d1b to
c67e46c
Compare
geminicaprograms
force-pushed
the
feat_lastOption_last
branch
from
abef2ed to
d60ce81
Compare
geminicaprograms
force-pushed
the
feat_fold
branch
2 times, most recently
from
e77c39d to
2740fe7
Compare
geminicaprograms
changed the base branch from
feat_lastOption_last
to
chore_improvements
geminicaprograms
force-pushed
the
chore_improvements
branch
from
2e33ffc to
7a1086d
Compare
geminicaprograms
force-pushed
the
feat_fold
branch
from
2740fe7 to
1529ba7
Compare
rucek
reviewed
Oct 27, 2023
| @@ -623,6 +623,42 @@ trait SourceOps[+T] { this: Source[T] => | |||
| * }}} | |||
| */ | |||
| def last(): T = lastOption().getOrElse(throw new NoSuchElementException("cannot obtain last from an empty source")) | |||
|
|
|||
| /** Uses `zero` as the current value and applies function `f` on it and a value received from a source. The returned value is used as the | |||
There was a problem hiding this comment.
suggestion: Please see the scaladoc-related comments for last/lastOption:
| import org.scalatest.matchers.should.Matchers | ||
| import ox.* | ||
|
|
||
| class SourceOpsFoldTest extends AnyFlatSpec with Matchers { |
There was a problem hiding this comment.
thought: Can we have another test case for a scenario where the function passed to fold throws an exception?
adamw
reviewed
Oct 30, 2023
adamw
reviewed
Oct 30, 2023
geminicaprograms
force-pushed
the
chore_improvements
branch
from
7a1086d to
856823e
Compare
geminicaprograms
force-pushed
the
feat_fold
branch
from
1529ba7 to
ba005a8
Compare
adamw
approved these changes
Oct 30, 2023
rucek
approved these changes
Oct 30, 2023
The `scope` should be only used in internals.
The `ChannelClosed.Error` offers convenient `toThrowable` function. It should be favoured over the new functionality development.
As mentioned in #27.
The `fold` operation returns combined value retrieved from running function `f` on all source elements in a cumulative manner where result of the previous call is used as an input value to the next e.g.: Source.empty[Int].fold(0)((acc, n) => acc + n) // 0 Source.fromValues(2, 3).fold(5)((acc, n) => acc - n) // 0 Note that in case when `receive()` operation fails then ChannelClosedException.Error exception is thrown. Wheres in case when function `f` throws then this exception is propagated up to the caller.
geminicaprograms
force-pushed
the
chore_improvements
branch
from
856823e to
4c456aa
Compare
geminicaprograms
force-pushed
the
feat_fold
branch
from
ba005a8 to
775f8db
Compare
geminicaprograms
added a commit
that referenced
this pull request
Oct 30, 2023
….scala` (#28) The following comments were applied: * use supervised instead of scoped * use toThrowable instead of ad-hoc exception creation * don't catch exceptions in headOption * also fixed comments about the source and receive function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
foldoperation returns combined value retrieved from running functionfon all source elements in a cumulative manner where result of the previous call is used as an input value to the next e.g.:Note that in case when
receive()operation fails then:NoSuchElementexception is thrown when source fails without errorffails with exception then this exception is propagated up to the caller