Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed tests #13576

Closed
wants to merge 4 commits into from
Closed

Fixed tests #13576

wants to merge 4 commits into from

Conversation

marcusmoore
Copy link
Collaborator

Description

This PR follows up #13575 and fixes a couple failed assertions.

@marcusmoore marcusmoore requested a review from snipe as a code owner September 7, 2023 21:36
@what-the-diff
Copy link

what-the-diff bot commented Sep 7, 2023

PR Summary

  • Enhanced User Attribute Testing
    Updated the assertions for various user attributes such as first name, last name, username, etc. This change means we now have more robust and comprehensive checks in place to ensure the program deals with user information reliably.

  • Group Updating Feature
    Added feature to update the groups a user is part of, by inputting an array of group IDs. This allows for greater flexibility in managing users' group affiliations.

@marcusmoore
Copy link
Collaborator Author

It might just be afternoon brain but it looks like Chipper isn't pulling in the change from the latest commit in that last build?

CleanShot 2023-09-07 at 16 12 00@2x

CleanShot 2023-09-07 at 16 13 30@2x

@marcusmoore
Copy link
Collaborator Author

I just realized Chipper isn't getting the messages ("User not marked as activated") either...

@marcusmoore
Copy link
Collaborator Author

Gonna close this and re-open to test something

@marcusmoore marcusmoore closed this Sep 7, 2023
@marcusmoore marcusmoore deleted the fixes/fix-test branch September 7, 2023 23:39
@marcusmoore marcusmoore mentioned this pull request Sep 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snipe snipe Awaiting requested review from snipe snipe is a code owner

Assignees
No one assigned
Labels
tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@marcusmoore