Skip to content

Release 4.2.0 #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 87 commits into from
Oct 26, 2016
Merged

Release 4.2.0 #907

merged 87 commits into from
Oct 26, 2016

Conversation

LuxoftAKutsan
Copy link
Contributor

No description provided.

Vladislav Antonov and others added 30 commits August 3, 2016 17:54
AppLaunch ini file modifications
a84b8ff 
Related issue : APPLINK-24892
@AGaliuzov
AppLaunch TM and CH implementation
2b41357 
Applaunch functionality in TransportMaanger and ConnectionHAndler implementation

Related issue : APPLINK-24892
@LuxoftAKutsan
AppLaunch Common interfaces
f0ab94e 
Related issue : APPLINK-24892
AppLaunchData common implementation
3d6ded9 
Related issue : APPLINK-24892
Divide ResumeCtrl onto interface and implementation
f6ebfe5 
`ResumeCtrl` was divided onto
interface and implementation.

Related to: APPLINK-24892
Divide HMICapabilities onto interface and implementation
1c2cf9c 
`HMICapabilities` was divided onto
interface and implementation.

Related to: APPLINK-24892
Reduce dependence of ApplicationManager
bc315e4 
Reduced dependence of `ApplicationManager`
from `ResumeCtrl` and `HMICapabilities`.

Related to: APPLINK-24892
@LuxoftAKutsan
Extend SDL interfaces for AppLaunch functionality
ee179e7 
Related issue : APPLINK-24892
@LuxoftAKutsan
Common AppLaunchController functionality
04ffa4a 
Related issue : APPLINK-24892
Fix coding style
8b74854 
Has been done:
- Fixed coding style;
- Fixed header guard naming;
- Fixed copyright comments.

Related to: APPLINK-24892
@anosach-luxoft
Merge pull request #737 from LevchenkoS/feature/AppLaunch
5b98543 
Feature AppLaunch
@seruhii
Complete covering of AppLaunch functionality by Unit Tests (#748)
834649f 
Has been covered:
- `ConnectionHandlerImpl::RunAppOnDevice`;
- `TransportManagerImpl::RunAppOnDevice`;
- `TransportAdapterImpl::RunAppOnDevice`;
- `ResumeCtrlImpl::GetSavedAppHmiLevel`.

Related to: APPLINK-24895
@LuxoftAKutsan
Skeleton of class that will handle avaliabllity if HMI interfaces
b191a30 
Related issue : APPLINK-20920
@LuxoftAKutsan
Set ready state for VR VI and UI interfaces
4028784 
 Related issue : APPLINK-20920
@LuxoftAKutsan
Fix Add command RPC
9bfcdc7 
Related issue : APPLINK-20920
@LuxoftAKutsan
Fix Create interaction choice set RPC
2271e7e 
Related issue : APPLINK-20920
@LuxoftAKutsan
Fix Delete Command RPC
f8e17cb 
Related issue : APPLINK-20920
@LuxoftAKutsan
Fix Read did RPC
4969513 
Related issue : APPLINK-20920
@LuxoftAKutsan
Make HmiInterfacesImpl Thread safe
662dcbb 
Related issue : APPLINK-20920
@LuxoftAKutsan
Add doxygen comments to HmiInterfacesImpl
29e68de
@LuxoftAKutsan
Fix typo
9df2535
@AGaliuzov
Merge pull request #760 from LuxoftAKutsan/feature/SDL_behaviour_if_V…
77d5152 
…R_not_avaliable

SDL behaviour if VR not available
@LuxoftAKutsan
Change variable name due to build error
3f73382
@AGaliuzov
Merge pull request #763 from LuxoftAKutsan/feature/SDL_behaviour_if_V…
ef2c8c7 
…R_not_avaliable

Change variable name due to build error
@LuxoftAKutsan @dtrunov
VehicleInfo interface: SDL behavior in case HMI does not respond to I…
443a470 
…sReady request or respond with "available" = false

Added logic for processing case when HMI does not respond to IsReady request or respond with "available"=false.
Based on implementation CRQ [APPLINK-20920](https://adc.luxoft.com/jira/browse/APPLINK-20920)

CRQ [APPLINK-25201](https://adc.luxoft.com/jira/browse/APPLINK-25201)
@anosach-luxoft
Merge pull request #750 from dtrunov/feature/VehicleInfo_interface_SD…
ad7336c 
…L_behavior_in_case_HMI_does_not_respond_to_IsReady_request_or_respond_with_available_false

VehicleInfo interface: SDL behavior in case HMI does not respond to IsReady request or respond with "available" = false
Create tools to test commands
0ebc989 
Been done:
- Added specific abstract classes for
  commands testing (CommandsTest
  and CommandRequestTest);
- Been added unit tests for base
  command classes (CommandImpl,
  CommandRequestImpl, CommandResponseImpl);
- Been added unit tests for next
  mobile response commands:
  - ListFilesResponse
  - ReadDIDResponse
  - AlertManeuverResponse
  - AlertResponse
  - SubscribeButtonResponse

Related to: APPLINK-24911
Move unit tests for mobile commands in release/4.2.0
d3d2bfd 
  - moved UT for mobile commands in release/4.2.0
  - added some unit tests for mobile commands

Related to APPLINK-20925
@AByzhynar
Merge pull request #754 from okozlovlux/feature/Move_UT_for_mobile_co…
58c450a 
…mmands_to_release_4_2_0

Feature/Move_unit_tests_for_mobile_commands
@nk0leg
Fix of SDL "SIGSEGV signal has been caught" when ending navi streaming
ca1e07f 
Related issue: [APPLINK-27161}(https://adc.luxoft.com/jira/browse/APPLINK-27161)
LuxoftAKutsan and others added 19 commits October 12, 2016 10:13
@LuxoftAKutsan
fixup! Add function_id check in request controller
2cabf0b
@LuxoftAKutsan
fixup! Add function_id check in request controller
9d172a2
@LuxoftAKutsan
Merge pull request #891 from LuxoftAKutsan/fix/response_function_id_c…
db5af6c 
…heck

Add function_id check in request controller
@LuxoftAKutsan
Send language param in RAI response if TTS is available
527c3d6 
Related issue : APPLINK-28819
@LuxoftAKutsan
Merge pull request #893 from LuxoftAKutsan/fix/send_language_if_tts_a…
18c9e8a 
…vailable

Send language param in RAI response if TTS is available
@LuxoftAKutsan
Remove redundant DCHECK if application unregisters during resumption …
781f4bc 
…timer

related issue : APPLINK-28817
@LuxoftAKutsan
Remove reduntant if to provide PrepareResultCodeForResponse function …
d9c8edf 
…resolve result code

relate issue : APPLINK-28797
@LuxoftAKutsan
Merge pull request #897 from LuxoftAKutsan/fix/rui_rejected_vr_unsupp…
b1329cb 
…orted_resource_delete_command

Fix/rui rejected vr unsupported resource delete command
@dtrunov
Fix problem with incorrect success result (#895)
88a1d59 
* Fix problem with incorrect success result

HMI send erronius result code and after that SDL answers with success=true. I fix this problem.
Fix UT according to new implementation.

Closes bug [APPLINK-28762](https://adc.luxoft.com/jira/browse/APPLINK-28762)
@OHerasym
Fix TTS IsReady false issues (#892)
7767e65 
* Fix TTS IsReady false issues

Related: APPLINK-28576, 28577, 28662
@dtrunov
Fix/sdl responds add command with incorrect info (#898)
6d6394c 
* Fix problem with merging info
Closes defect [APPLINK-28758](https://adc.luxoft.com/jira/browse/APPLINK-28758)
@OHerasym
Fix change registration wrong code (#902)
671ff4b 
* Fix change registration wrong code

Related: APPLINK-28910, 28905
@seruhii
Fix broken test case in RegisterAppInterfaceRequestTest
2a6715a 
Test case `RegisterAppInterfaceRequestTest
.Run_HmiInterfacesStateAvailable_SUCCESS`
has been fixed.

Related to: APPLINK-28912
@anosach-luxoft
Merge pull request #901 from LevchenkoS/fix/Fix_broken_test_case_in_R…
eecb26d 
…egisterAppInterfaceRequestTest

Fix broken test case in RegisterAppInterfaceRequestTest
@dtrunov
Fix problem with merging info for delete command (#903)
220eab8 
Closes defect [APPLINK-28944](https://adc.luxoft.com/jira/browse/APPLINK-28944)
@OHerasym
Add Unit Tests to TTS IsReady false (#886)
0d68615 
* Add Unit Tests to TTS IsReady false

Add uncovered cases to change registration

Related: APPLINK-25123
Related: APPLINK-25122
@seruhii
Cover by UT navigation interface behavior (#899)
bcb354a 
Has been covered SDL commands
behavior in case HMI does
not respond to `IsReadyRequest`,
or respond with `available == false`.

Related to: APPLINK-25174
Create unit tests for commands UI (#882)
86d08a4 
* Create unit test for mobile commands

  - created UT for mobile commands for UI interface for checking
    SDL behavior in case HMI does not respond to IsReady_request
    or respond with "available" = false.
    Command list:
	1. Alert
	2. Show
	3. AddCommand
	4. DeleteCommand
	5. AddSubMenu
    	6. DeleteSubMenu
	7. PerformInteraction
	8. SetMediaClockTimer
	9. SetGlobalProperties
	10. ChangeRegistration
	11. SetAppIcon
	12. SetDisplayLayout
	13. Slider
	14. ScrollableMessage
	15. PerformAudioPassThru
	16. EndAudioPassThru

Related to APPLINK-25091
@LuxoftAKutsan
Merge commit '5bf2c5500309d36b60987e74bdd4ed1610ecffde' into release/…
4374842 
…4.2.0
@Jack-Byrne
Copy link
Collaborator

Jack-Byrne commented Oct 17, 2016 •
edited
Loading

@dtrunov I noticed that there is no "onTimeout()" function implemented for the navigation is ready request.

@LuxoftAKutsan @mghiumiusliu @AnastasiyaBritanova Also why is the behavior to send messages to HMI components when a timeout for an is ready request occurs? If an HMI component doesn't respond to the is ready request wouldn't it be assumed that the component is unavailable?

Also what is the expected behavior for when the HMI reports that a component is NOT ready?

@dtrunov
Copy link
Contributor

dtrunov commented Oct 18, 2016 •
edited
Loading

@JackLivio: "I noticed that there is no "onTimeout()" function implemented for the navigation is ready request".
There are no specific behavior in case Navigation interface is timed out.

@LuxoftAKutsan
Copy link
Contributor Author

LuxoftAKutsan commented Oct 18, 2016 •
edited
Loading

@JackLivio it is correct behaviour according to requirements to avoid missing resources in case if IsReady stubs on HMI.

I case if HMI didn't respond to INTERFACE.IsReady() request SDL still should send INTERFACE specific requests and wait responses, in case time out for them send GENERIC_ERROR to mobile.

I case if HMI respond to INTERFACE.IsReady() request with available=true SDL should send INTERFACE specific requests and wait responses, in case time out for them send GENERIC_ERROR to mobile

I case if HMI respond to INTERFACE.IsReady() request with available=false SDL should not send INTERFACE specific requests and respond UNSUPPORTED_RESOURCE to mobile.

@AnastasiyaBritanova please approve or amend.

seruhii and others added 2 commits October 19, 2016 10:05
@seruhii
Fix that StartStreamRequest may hang forever in case of app absence
77439a1 
In `AudioStartStreamRequest`
and `NaviStartStreamRequest`,
subscription to event and
disabling of `AllowedToTerminate`
flag, has been moved after checking
for applications presence.

Closes bug: APPLINK-28988
@AByzhynar
Merge pull request #904 from LevchenkoS/fix/Fix_that_start_stream_req…
5550953 
…uest_may_hang_forever_in_case_of_app_absence

Fix that StartStreamRequest may hang forever in case of app absence
@AnastasiyaBritanova
Copy link

@LuxoftAKutsan , what you described above is correct.

@seruhii seruhii mentioned this pull request Oct 20, 2016
Closed
@jacobkeeler
Merge branch 'master'
fc832c7 
Conflicts:
	src/components/application_manager/src/request_controller.cc
@jacobkeeler jacobkeeler merged commit a6c32b4 into master Oct 26, 2016
@jacobkeeler jacobkeeler deleted the release/4.2.0 branch March 7, 2017 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.