Feature AppLaunch #737

seruhii · 2016-08-03T06:01:30Z

Feature allows SDL to launch apps on connected devices.

Related to: APPLINK-24892

@okozlovlux, @Kozoriz, @LuxoftAKutsan, @vlantonov, @wolfylambova22, @VVeremjova, please review.

vlantonov · 2016-08-03T06:15:10Z

@LevchenkoS Is this pull request rebased to the latest commit in develop branch?

seruhii · 2016-08-03T06:16:48Z

@vlantonov, no, it's for release/4.2.0, based on release/4.1.0

vlantonov · 2016-08-03T06:20:22Z

@LevchenkoS Please try to rebase to the latest commit of release/4.2.0 This pull request contains commits from other people while it is supposed to contain only your commits, related to APPLINK-24892

seruhii · 2016-08-03T06:22:47Z

@vlantonov, sorry, but it should contains them. Please, look at email that I was sent to you and other reviewers.

vlantonov · 2016-08-03T06:26:30Z

@LevchenkoS No, it shouldn't. These commits are from other pull request and are already reviewed and merged. However they appear as changes you have made and thus will be reviewed again. I repeat - please rebase your pull request to the latest commit in release/4.2.0

vlantonov · 2016-08-03T06:38:05Z

@LevchenkoS As far as I understand from your explaination those commits are cherry-picked and that is why they should be here. So this is OK.

LuxoftAKutsan · 2016-08-03T06:46:17Z

src/components/application_manager/src/resumption/resume_ctrl.cc

@@ -696,7 +701,11 @@ bool ResumeCtrl::CheckDelayAfterIgnOn() {
  return seconds_from_sdl_start <= wait_time;
 }

+<<<<<<< HEAD:src/components/application_manager/src/resumption/resume_ctrl.cc


@LevchenkoS remove merge issues

@LuxoftAKutsan, fixed in f6ebfe5.

wolfylambova22 · 2016-08-03T07:23:12Z

Reviewed.

vlantonov · 2016-08-03T08:21:37Z

src/components/application_manager/include/application_manager/resumption/resume_ctrl_impl.h

+   * @param application is application witch HMI Level is need to restore
+   * @return true if success, otherwise return false
+   */
+  bool RestoreAppHMIState(app_mngr::ApplicationSharedPtr application);


@LevchenkoS Please add OVERRIDE here and in the other methods inherited from ResumeCtrl

@vlantonov, fixed in f6ebfe5.

Related issue : APPLINK-24892

Applaunch functionality in TransportMaanger and ConnectionHAndler implementation Related issue : APPLINK-24892

codecov-io · 2016-08-04T11:56:15Z

Current coverage is 68.86% (diff: 75.39%)

Merging #737 into release/4.2.0 will increase coverage by 0.31%

@@           release/4.2.0       #737   diff @@
===============================================
  Files                313        331    +18   
  Lines              22583      23366   +783   
  Methods                0          0          
  Messages               0          0          
  Branches               0          0          
===============================================
+ Hits               15479      16090   +611   
- Misses              7104       7276   +172   
  Partials               0          0

Powered by Codecov. Last update edbd60e...8b74854

Kozoriz · 2016-08-04T13:13:06Z

src/components/application_manager/src/hmi_capabilities_impl.cc

  hmi_language_handler_.Init(last_state);
  if (false == load_capabilities_from_file()) {
    LOG4CXX_ERROR(logger_, "file hmi_capabilities.json was not loaded");
  } else {
-    LOG4CXX_INFO(logger_, "file hmi_capabilities.json was loaded");
+    LOG4CXX_ERROR(logger_, "file hmi_capabilities.json was loaded");


Maybe this is just info?

@Kozoriz, fixed in 1c2cf9c.

Kozoriz · 2016-08-04T13:24:34Z

src/components/application_manager/test/include/application_manager/mock_resume_ctrl.h

+#include "application_manager/application.h"
+#include "resumption/last_state.h"
+
+namespace resumption {


incorrect namespaces
test -> components -> resumprion_test

@Kozoriz, fixed in f6ebfe5.

Related issue : APPLINK-24892

`ResumeCtrl` was divided onto interface and implementation. Related to: APPLINK-24892

`HMICapabilities` was divided onto interface and implementation. Related to: APPLINK-24892

Reduced dependence of `ApplicationManager` from `ResumeCtrl` and `HMICapabilities`. Related to: APPLINK-24892

Related issue : APPLINK-24892

Kozoriz · 2016-08-05T07:27:54Z

Reviewed

VVeremjova · 2016-08-05T07:31:23Z

src/components/application_manager/include/application_manager/app_launch/app_launch_ctrl.h

+namespace application_manager {
+class Application;
+typedef utils::SharedPtr<const Application> ApplicationConstSharedPtr;
+}  // namesapce application_manager


@LevchenkoS typo

@VVeremjova, fixed in 9926c88.

vlantonov · 2016-08-05T07:41:56Z

@LevchenkoS Reviewed.

VVeremjova · 2016-08-05T07:50:00Z

src/components/application_manager/test/hmi_capabilities_test.cc

@@ -94,7 +98,7 @@ class HMICapabilitiesTest : public ::testing::Test {
  resumption::LastState last_state_;
  MockApplicationManagerSettings mock_application_manager_settings_;
  utils::SharedPtr<HMICapabilitiesForTesting> hmi_capabilities_test;
-  const std::string kFileName = "hmi_capabilities.json";
+  std::string file_name_;


@LevchenkoS You could leave const here

@VVeremjova, fixed in 8e37c0c.

kozlov-oleksandr · 2016-08-05T08:45:31Z

@LevchenkoS , reviewed

VVeremjova · 2016-08-05T08:48:07Z

@LevchenkoS Reviewed

LuxoftAKutsan · 2016-08-05T09:21:40Z

src/components/include/application_manager/app_launch_settings.h

+  virtual const uint16_t max_number_of_ios_device() const = 0;
+  virtual const uint16_t wait_time_between_apps() const = 0;
+  virtual const bool enable_app_launch_ios() const = 0;
+  virtual uint32_t resumption_delay_after_ign() const = 0;


@LevchenkoS
either add const to return value or remove const in others

@LuxoftAKutsan, fixed in c9dfbce.

LuxoftAKutsan · 2016-08-05T09:27:39Z

Reviewed

Related issue : APPLINK-24892

Has been done: - Fixed coding style; - Fixed header guard naming; - Fixed copyright comments. Related to: APPLINK-24892

LuxoftAKutsan reviewed Aug 3, 2016
View reviewed changes

vlantonov reviewed Aug 3, 2016
View reviewed changes

Vladislav Antonov and others added 2 commits August 3, 2016 17:54

AppLaunch ini file modifications

a84b8ff

Related issue : APPLINK-24892

AppLaunch TM and CH implementation

2b41357

Applaunch functionality in TransportMaanger and ConnectionHAndler implementation Related issue : APPLINK-24892

Kozoriz reviewed Aug 4, 2016
View reviewed changes

LuxoftAKutsan and others added 6 commits August 4, 2016 17:30

AppLaunch Common interfaces

f0ab94e

Related issue : APPLINK-24892

AppLaunchData common implementation

3d6ded9

Related issue : APPLINK-24892

Divide ResumeCtrl onto interface and implementation

f6ebfe5

`ResumeCtrl` was divided onto interface and implementation. Related to: APPLINK-24892

Divide HMICapabilities onto interface and implementation

1c2cf9c

`HMICapabilities` was divided onto interface and implementation. Related to: APPLINK-24892

Reduce dependence of ApplicationManager

bc315e4

Reduced dependence of `ApplicationManager` from `ResumeCtrl` and `HMICapabilities`. Related to: APPLINK-24892

Extend SDL interfaces for AppLaunch functionality

ee179e7

Related issue : APPLINK-24892

VVeremjova reviewed Aug 5, 2016
View reviewed changes

LuxoftAKutsan reviewed Aug 5, 2016
View reviewed changes

LuxoftAKutsan and others added 2 commits August 5, 2016 15:40

Common AppLaunchController functionality

04ffa4a

Related issue : APPLINK-24892

Fix coding style

8b74854

Has been done: - Fixed coding style; - Fixed header guard naming; - Fixed copyright comments. Related to: APPLINK-24892

anosach-luxoft merged commit 5b98543 into smartdevicelink:release/4.2.0 Aug 5, 2016

ShobhitAd mentioned this pull request Jan 20, 2021

Fix/RAI appInfo since attribute smartdevicelink/rpc_spec#311

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature AppLaunch #737

Feature AppLaunch #737

seruhii commented Aug 3, 2016 •

edited

Loading

vlantonov commented Aug 3, 2016

seruhii commented Aug 3, 2016

vlantonov commented Aug 3, 2016

seruhii commented Aug 3, 2016

vlantonov commented Aug 3, 2016

vlantonov commented Aug 3, 2016

LuxoftAKutsan Aug 3, 2016

seruhii Aug 3, 2016 •

edited

Loading

wolfylambova22 commented Aug 3, 2016

vlantonov Aug 3, 2016

seruhii Aug 3, 2016 •

edited

Loading

codecov-io commented Aug 4, 2016 •

edited

Loading

Kozoriz Aug 4, 2016

seruhii Aug 5, 2016

Kozoriz Aug 4, 2016

seruhii Aug 5, 2016

Kozoriz commented Aug 5, 2016

VVeremjova Aug 5, 2016

seruhii Aug 5, 2016 •

edited

Loading

vlantonov commented Aug 5, 2016

VVeremjova Aug 5, 2016

seruhii Aug 5, 2016 •

edited

Loading

kozlov-oleksandr commented Aug 5, 2016

VVeremjova commented Aug 5, 2016

LuxoftAKutsan Aug 5, 2016

seruhii Aug 5, 2016 •

edited

Loading

LuxoftAKutsan commented Aug 5, 2016

Feature AppLaunch #737

Feature AppLaunch #737

Conversation

seruhii commented Aug 3, 2016 • edited Loading

vlantonov commented Aug 3, 2016

seruhii commented Aug 3, 2016

vlantonov commented Aug 3, 2016

seruhii commented Aug 3, 2016

vlantonov commented Aug 3, 2016

vlantonov commented Aug 3, 2016

Choose a reason for hiding this comment

seruhii Aug 3, 2016 • edited Loading

Choose a reason for hiding this comment

wolfylambova22 commented Aug 3, 2016

Choose a reason for hiding this comment

seruhii Aug 3, 2016 • edited Loading

Choose a reason for hiding this comment

codecov-io commented Aug 4, 2016 • edited Loading

Current coverage is 68.86% (diff: 75.39%)

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Kozoriz commented Aug 5, 2016

Choose a reason for hiding this comment

seruhii Aug 5, 2016 • edited Loading

Choose a reason for hiding this comment

vlantonov commented Aug 5, 2016

Choose a reason for hiding this comment

seruhii Aug 5, 2016 • edited Loading

Choose a reason for hiding this comment

kozlov-oleksandr commented Aug 5, 2016

VVeremjova commented Aug 5, 2016

Choose a reason for hiding this comment

seruhii Aug 5, 2016 • edited Loading

Choose a reason for hiding this comment

LuxoftAKutsan commented Aug 5, 2016

seruhii commented Aug 3, 2016 •

edited

Loading

seruhii Aug 3, 2016 •

edited

Loading

seruhii Aug 3, 2016 •

edited

Loading

codecov-io commented Aug 4, 2016 •

edited

Loading

seruhii Aug 5, 2016 •

edited

Loading

seruhii Aug 5, 2016 •

edited

Loading

seruhii Aug 5, 2016 •

edited

Loading