DPA-1413: fix(solana): IsOperation in timelock inspector #231
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@smartcontractkit/mcms": minor | ||
| --- | ||
|
|
||
| feat(solana): timelock inspection - operation statuses check |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,131 @@ | ||
| package solana | ||
|
|
||
| import ( | ||
| "context" | ||
| "errors" | ||
|
|
||
| "github.com/ethereum/go-ethereum/common" | ||
| "github.com/gagliardetto/solana-go/rpc" | ||
| "github.com/smartcontractkit/chainlink-ccip/chains/solana/gobindings/mcm" | ||
| "github.com/smartcontractkit/chainlink-ccip/chains/solana/gobindings/timelock" | ||
| solanaCommon "github.com/smartcontractkit/chainlink-ccip/chains/solana/utils/common" | ||
|
|
||
| "github.com/smartcontractkit/mcms/sdk" | ||
| ) | ||
|
|
||
| var _ sdk.TimelockInspector = (*TimelockInspector)(nil) | ||
|
|
||
| var TimelockOpDoneTimestamp = uint64(1) | ||
|
|
||
| // TimelockInspector is an Inspector implementation for Solana chains for accessing the RBACTimelock contract | ||
| type TimelockInspector struct { | ||
| client *rpc.Client | ||
| } | ||
|
|
||
| // NewTimelockInspector creates a new TimelockInspector | ||
| func NewTimelockInspector(client *rpc.Client) *TimelockInspector { | ||
| return &TimelockInspector{client: client} | ||
| } | ||
|
|
||
| func (t TimelockInspector) GetProposers(ctx context.Context, address string) ([]common.Address, error) { | ||
| panic("implement me") | ||
| } | ||
|
|
||
| func (t TimelockInspector) GetExecutors(ctx context.Context, address string) ([]common.Address, error) { | ||
| panic("implement me") | ||
| } | ||
|
|
||
| func (t TimelockInspector) GetBypassers(ctx context.Context, address string) ([]common.Address, error) { | ||
| panic("implement me") | ||
| } | ||
|
|
||
| func (t TimelockInspector) GetCancellers(ctx context.Context, address string) ([]common.Address, error) { | ||
| panic("implement me") | ||
| } | ||
|
|
||
| func (t TimelockInspector) IsOperation(ctx context.Context, address string, opID [32]byte) (bool, error) { | ||
| _, err := t.getOpData(ctx, address, opID) | ||
| if err != nil { | ||
| if errors.Is(err, rpc.ErrNotFound) { | ||
| return false, nil | ||
| } | ||
|
|
||
| return false, err | ||
| } | ||
|
|
||
| return true, nil | ||
| } | ||
|
|
||
| func (t TimelockInspector) IsOperationPending(ctx context.Context, address string, opID [32]byte) (bool, error) { | ||
| op, err := t.getOpData(ctx, address, opID) | ||
| if err != nil { | ||
| return false, err | ||
| } | ||
|
|
||
| return op.Timestamp > TimelockOpDoneTimestamp, nil | ||
| } | ||
|
|
||
| func (t TimelockInspector) IsOperationReady(ctx context.Context, address string, opID [32]byte) (bool, error) { | ||
| op, err := t.getOpData(ctx, address, opID) | ||
| if err != nil { | ||
| return false, err | ||
| } | ||
|
|
||
| blockTime, err := solanaCommon.GetBlockTime(ctx, t.client, rpc.CommitmentConfirmed) | ||
| if err != nil { | ||
| return false, err | ||
| } | ||
|
|
||
| ts, err := safeConvertUint64ToInt64(op.Timestamp) | ||
| if err != nil { | ||
| return false, err | ||
| } | ||
|
|
||
| // a safety catch to prevent nil blocktime - ideally should not happen | ||
| if blockTime == nil { | ||
| return false, errors.New("failed to get block time: nil value") | ||
| } | ||
|
|
||
| return op.Timestamp > TimelockOpDoneTimestamp && ts <= int64(*blockTime), nil | ||
|
There was a problem hiding this comment. we have to perform these check manually because anchor-go does not generate bindings for these. There was a problem hiding this comment. Can we be 100% sure that There was a problem hiding this comment. i can add a guard to be safe. |
||
| } | ||
|
|
||
| func (t TimelockInspector) IsOperationDone(ctx context.Context, address string, opID [32]byte) (bool, error) { | ||
| op, err := t.getOpData(ctx, address, opID) | ||
| if err != nil { | ||
| return false, err | ||
| } | ||
|
|
||
| return op.Timestamp == TimelockOpDoneTimestamp, nil | ||
| } | ||
|
|
||
| func (t TimelockInspector) getOpData(ctx context.Context, address string, opID [32]byte) (timelock.Operation, error) { | ||
| programID, seed, err := ParseContractAddress(address) | ||
| if err != nil { | ||
| return timelock.Operation{}, err | ||
| } | ||
|
|
||
| mcm.SetProgramID(programID) | ||
|
|
||
| pda, err := FindTimelockOperationPDA(programID, seed, opID) | ||
| if err != nil { | ||
| return timelock.Operation{}, err | ||
| } | ||
|
|
||
| var opAccount timelock.Operation | ||
| err = solanaCommon.GetAccountDataBorshInto(ctx, t.client, pda, rpc.CommitmentConfirmed, &opAccount) | ||
| if err != nil { | ||
| return timelock.Operation{}, err | ||
| } | ||
|
|
||
| return opAccount, nil | ||
| } | ||
|
|
||
| func safeConvertUint64ToInt64(value uint64) (int64, error) { | ||
| const maxInt64 = int64(^uint64(0) >> 1) | ||
|
|
||
| if value > uint64(maxInt64) { | ||
| return 0, errors.New("cannot convert uint64 to int64: value out of int64 range") | ||
| } | ||
|
|
||
| return int64(value), nil | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rather than converting, could you make
TimelockOpDoneTimestampinto a uint64?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you mean something like
uint64(op.Timestamp), then lint will complain