DPA-1413: fix(solana): IsOperation in timelock inspector #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6138e73 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
graham-chainlink
changed the title
| return false, err | ||
| } | ||
|
|
||
| return op.Timestamp > TimelockOpDoneTimestamp && ts <= int64(*blockTime), nil |
There was a problem hiding this comment.
we have to perform these check manually because anchor-go does not generate bindings for these.
There was a problem hiding this comment.
Can we be 100% sure that blockTime != nil when err == nil?
There was a problem hiding this comment.
i can add a guard to be safe.
jkongie
reviewed
Jan 10, 2025
| return false, err | ||
| } | ||
|
|
||
| ts, err := safeConvertUint64ToInt64(op.Timestamp) |
There was a problem hiding this comment.
rather than converting, could you make TimelockOpDoneTimestamp into a uint64?
There was a problem hiding this comment.
if you mean something like uint64(op.Timestamp) , then lint will complain
sdk/solana/timelock_inspector.go:79:12: G115: integer overflow conversion uint64 -> int64 (gosec)
i := int64(op.Timestamp)
9dc4f67 to
0ccaaf0
Compare
graham-chainlink
changed the title
graham-chainlink
force-pushed
the
ggoh/DPA-1421/timelock-inspection-status
branch
2 times, most recently
from
f465bd3 to
a388943
Compare
graham-chainlink
force-pushed
the
ggoh/DPA-1421/timelock-inspection-status
branch
from
a388943 to
c5e507f
Compare
sdk/solana/timelock_inspector.go
Outdated
|
|
||
| mcm.SetProgramID(programID) | ||
|
|
||
| pda, err := FindTimelockOperationPDA(programID, seed) |
There was a problem hiding this comment.
As I said in the slack thread, I think this is missing the operation ID:
func GetOperationPDA(timelockID [32]byte, opID [32]byte) solana.PublicKey {
pda, _, _ := solana.FindProgramAddress([][]byte{
[]byte("timelock_operation"),
timelockID[:],
opID[:],
}, config.TimelockProgram)
return pda
}There was a problem hiding this comment.
Alright updated! Thanks!
graham-chainlink
force-pushed
the
ggoh/DPA-1421/timelock-inspection-status
branch
3 times, most recently
from
8391d70 to
ba205f5
Compare
gustavogama-cll
previously approved these changes
Jan 14, 2025
@gustavogama-cll |
Implement status operation check for timelock inspector for solana. e2e test will come in another PR as that involves more setup and work. JIRA: https://smartcontract-it.atlassian.net/browse/DPA-1413
graham-chainlink
force-pushed
the
ggoh/DPA-1421/timelock-inspection-status
branch
from
ba205f5 to
6138e73
Compare
|
gustavogama-cll
approved these changes
Jan 14, 2025
akhilchainani
pushed a commit
that referenced
this pull request
Jan 28, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @smartcontractkit/[email protected] ### Minor Changes - [#256](#256) [`45c6a2e`](45c6a2e) Thanks [@akhilchainani](https://github.com/akhilchainani)! - Allow callProxy execute capability - [#245](#245) [`7a5944e`](7a5944e) Thanks [@gustavogama-cll](https://github.com/gustavogama-cll)! - Add context and Converter map TimelockConverter.Convert params - [#231](#231) [`a8447e1`](a8447e1) Thanks [@graham-chainlink](https://github.com/graham-chainlink)! - feat(solana): timelock inspection - operation statuses check - [#242](#242) [`c610826`](c610826) Thanks [@gustavogama-cll](https://github.com/gustavogama-cll)! - Add TimelockProposal.Convert for solana - [#238](#238) [`abde70c`](abde70c) Thanks [@graham-chainlink](https://github.com/graham-chainlink)! - feat(solana): implement get roles for timelock inspection - [#236](#236) [`150a1f6`](150a1f6) Thanks [@graham-chainlink](https://github.com/graham-chainlink)! - Use string for inspector return type - [#209](#209) [`a71dd79`](a71dd79) Thanks [@gustavogama-cll](https://github.com/gustavogama-cll)! - Add the `Configurer` component and `SetConfig` call to the Solana SDK. - [#223](#223) [`4adb968`](4adb968) Thanks [@gustavogama-cll](https://github.com/gustavogama-cll)! - Add a "context" parameter to all APIs that interact with a blockchain. - [#227](#227) [`21d8809`](21d8809) Thanks [@ecPablo](https://github.com/ecPablo)! - Adds Execute functionality to solana SDK - [#248](#248) [`e153c75`](e153c75) Thanks [@ecPablo](https://github.com/ecPablo)! - Timelock execute batch on solana SDK. - [#211](#211) [`be76399`](be76399) Thanks [@graham-chainlink](https://github.com/graham-chainlink)! - feat(solana): support get opdata, root and root metadata ### Patch Changes - [#215](#215) [`9f39403`](9f39403) Thanks [@gustavogama-cll](https://github.com/gustavogama-cll)! - Add the `Executor` component and `SetRoot` call to the Solana SDK. - [#259](#259) [`a4bc13b`](a4bc13b) Thanks [@anirudhwarrier](https://github.com/anirudhwarrier)! - usbwallet: fix ledger access for latest firmware and add Ledger Flex - [#225](#225) [`7c9cd3d`](7c9cd3d) Thanks [@gustavogama-cll](https://github.com/gustavogama-cll)! - Add PDA finders and ContractAddress parser to the Solana SDK - [#258](#258) [`a11a0ee`](a11a0ee) Thanks [@akhilchainani](https://github.com/akhilchainani)! - non-breaking change to allow a salt override to proposals - [#228](#228) [`b953973`](b953973) Thanks [@graham-chainlink](https://github.com/graham-chainlink)! - fix(solana): setProgramID on inspection methods Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement status operation check for timelock inspector for solana.
e2e tests will come in another PR as that involves more setup and work.
JIRA: https://smartcontract-it.atlassian.net/browse/DPA-1413
Below is a summarization created by an LLM (gpt-4o-2024-08-06). Be mindful of hallucinations and verify accuracy.
Why
Introduces a new
TimelockInspectorfor Solana chains to access the RBACTimelock contract, providing functionalities to check operation status and manage timelock operations effectively.What
TimelockInspectorstruct and methods for Solana chainsIsOperationto check operation existenceIsOperationPendingto check pending statusIsOperationReadyto check readiness statusIsOperationDoneto check completion statusgetOpDatato retrieve operation datasafeConvertUint64ToInt64for safe type conversion