Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove some platform-specific quirkinesses from e2e #602

Merged
merged 4 commits into from
Nov 22, 2024

Conversation

LoricAndre
Copy link
Contributor

No description provided.

@LoricAndre LoricAndre added this to the v0.12.0 milestone Nov 20, 2024
LoricAndre added 2 commits November 20, 2024 17:50
This reverts commit ed065c3.
@LoricAndre LoricAndre requested a review from yazgoo November 20, 2024 21:58
@LoricAndre LoricAndre self-assigned this Nov 20, 2024
@LoricAndre
Copy link
Contributor Author

  • replaces xxd with the more common hexdump
  • uses python native functions instead of bash check for history-files tests
  • extra formatting

@LoricAndre LoricAndre merged commit 63f4e33 into master Nov 22, 2024
5 checks passed
@LoricAndre LoricAndre deleted the chore/normalize-e2e branch November 22, 2024 19:56
khafatech pushed a commit to khafatech/skim that referenced this pull request Nov 23, 2024
* chore: remove some platform-specific quirkinesses from e2e

* debug

* Revert "debug"

This reverts commit ed065c3.

---------

Co-authored-by: LoricAndre <[email protected]>
LoricAndre added a commit that referenced this pull request Nov 26, 2024
* Fix example link in README.md

* Fix typo and improve punctuation

* change example url to the correct repo

* Fix some links and wording

* Add support for install on Linux armv7l, aarch64 and Darwin arm64 (#413)

Also,

- Use the Github API to download the latest `version`
- Use the new release artefact format
- Fix grep pattern to work across Mac / Linux
- Fix version check to strip out `sk` prefix
- Exit when existing version already matches

This allows the install script to work with Raspbian running on a
Raspberry Pi

* chore: remove some platform-specific quirkinesses from e2e (#602)

* chore: remove some platform-specific quirkinesses from e2e

* debug

* Revert "debug"

This reverts commit ed065c3.

---------

Co-authored-by: LoricAndre <[email protected]>

* Improve grammar and wording in the readme

---------

Co-authored-by: LoricAndre <[email protected]>
Co-authored-by: Rohan Jain <[email protected]>
Co-authored-by: LoricAndre <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant