Add support for install on armv7 and aarch64 #413
Conversation
crodjer
changed the title
|
Hi @lotabout / maintainers, requesting a review for these changes. |
|
A refactor of the CI is in the works, this will be part of it. |
crodjer
force-pushed
the
install-armv7
branch
4 times, most recently
from
34bccbd to
673530b
Compare
|
This looks good ! I'll test the different architectures to make sure everything works, and we'll be good to merge this quickly |
|
@LoricAndre One thing that I discovered, the |
|
It was a miss, I just noticed it while testing. A hotfix should be available as v0.11.11 in a few minutes |
|
Should be good |
|
While we're at it, do you know what the output of |
|
I'd like to merge this quickly, as it made me realize that the install script needs a lot of work to make it more usable, and I'll start working on it as soon as we're done with this change |
|
crodjer
force-pushed
the
install-armv7
branch
from
673530b to
3f1c0ab
Compare
|
@LoricAndre Added Darwin arm64 and a fallback message for the unknown platforms. |
crodjer
force-pushed
the
install-armv7
branch
from
3f1c0ab to
213dbd0
Compare
Also, - Use the Github API to download the latest `version` - Use the new release artefact format - Fix grep pattern to work across Mac / Linux - Fix version check to strip out `sk` prefix - Exit when existing version already matches This allows the install script to work with Raspbian running on a Raspberry Pi
crodjer
force-pushed
the
install-armv7
branch
from
213dbd0 to
803abdc
Compare
|
@LoricAndre I realized that the version check also wasn't working right (as there is |
|
Is this working on MacOS now ? |
|
If it is, then everything LGTM |
|
Yes, I think should be good. |
…im-rs#413) Also, - Use the Github API to download the latest `version` - Use the new release artefact format - Fix grep pattern to work across Mac / Linux - Fix version check to strip out `sk` prefix - Exit when existing version already matches This allows the install script to work with Raspbian running on a Raspberry Pi
* Fix example link in README.md * Fix typo and improve punctuation * change example url to the correct repo * Fix some links and wording * Add support for install on Linux armv7l, aarch64 and Darwin arm64 (#413) Also, - Use the Github API to download the latest `version` - Use the new release artefact format - Fix grep pattern to work across Mac / Linux - Fix version check to strip out `sk` prefix - Exit when existing version already matches This allows the install script to work with Raspbian running on a Raspberry Pi * chore: remove some platform-specific quirkinesses from e2e (#602) * chore: remove some platform-specific quirkinesses from e2e * debug * Revert "debug" This reverts commit ed065c3. --------- Co-authored-by: LoricAndre <[email protected]> * Improve grammar and wording in the readme --------- Co-authored-by: LoricAndre <[email protected]> Co-authored-by: Rohan Jain <[email protected]> Co-authored-by: LoricAndre <[email protected]>
This allows the script to work with Raspbian/Arch/Manjaro running on a Raspberry Pi