Escape double quotes in UDMF string values when saving

Fixes #1453 Also added some missing defaults for UDMF properties
sirjuddington · Mar 30, 2023 · d532bce · d532bce
1 parent 28895c5
commit d532bce
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/dist/res/config/ports/include/props_zdoom.cfg b/dist/res/config/ports/include/props_zdoom.cfg
@@ -893,11 +893,13 @@ udmf_properties
 			{
 				name = "Pitch";
 				type = int;
+				default = 0;
 			}
 			property roll
 			{
 				name = "Roll";
 				type = int;
+				default = 0;
 			}
 			property scale
 			{
@@ -1025,14 +1027,16 @@ udmf_properties
 			{
 				name = "Render Style";
 				type = string;
-				values="", "Normal", "None", "Add", "Subtract", "Stencil", "AddStencil", "TranslucentStencil", "Translucent", "Fuzzy", "OptFuzzy", "Soultrans", "Shaded", "AddShaded", "Shadow";
+				values = "", "Normal", "None", "Add", "Subtract", "Stencil", "AddStencil", "TranslucentStencil", "Translucent", "Fuzzy", "OptFuzzy", "Soultrans", "Shaded", "AddShaded", "Shadow";
+				default = "";
 			}
 		}
 
 		group "Miscellaneous"
 		{
 			show_always = false;
 			type = int;
+			default = 0;
 
 			property floatbobphase = "Bobbing Phase";
 			property gravity

diff --git a/src/Utility/Property.cpp b/src/Utility/Property.cpp
@@ -149,6 +149,7 @@ string PropertyList::toString(bool condensed, int float_precision) const
 
 		if (property::valueType(prop.value) == property::ValueType::String)
 		{
+			val = strutil::escapedString(val);
 			val.insert(val.begin(), '\"');
 			val.push_back('\"');
 		}