Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improper handling of quotes within the comment field #1453

Closed
Blue-Shadow opened this issue Jan 17, 2023 · 0 comments
Closed

Improper handling of quotes within the comment field #1453

Blue-Shadow opened this issue Jan 17, 2023 · 0 comments

Comments

@Blue-Shadow
Copy link
Contributor

SLADE Version: (3.2.1)
Operating System: Windows

Issue Details:
If you assign a thing/linedef/sector/etc. a comment which contains quotes, something like: blah "foo" bar. SLADE doesn't escape those quotes when generating the TEXTMAP lump of the map, which makes the map fails to load in GZDoom with a parsing error. SLADE also becomes unable to load the map, stating that it's invalid.

If you load this file with GZDoom, you'll get this error upon starting a new game on MAP01:

Script error, "MAP01" line 41:
Expected ';' but got identifier 'mysterious' instead.

This is line 41 in the map's TEXTMAP lump:

comment="The "mysterious" lamp";

Which should be like this:

comment="The \"mysterious\" lamp";
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant