Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jsdom 2 #248

Merged
merged 2 commits into from
Aug 4, 2019
Merged

Fix jsdom 2 #248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a1a89a
Test to verify that lolex works with JSDOM configured to provide glob…
cdow2-godaddy Jun 22, 2019
629ca1a
Fix support for replacing the JSDOM performance field
cdow2-godaddy Aug 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 80 additions & 0 deletions integration-test/lolex-integration-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,3 +57,83 @@ describe("withGlobal", function () {
clock.uninstall();
});
});

describe("globally configured browser objects", function () {
var withGlobal, originalDescriptors;

// Used to support Node 6 which doesn't support Object.getOwnPropertyDescriptors
Copy link
Contributor

@fatso83 fatso83 Aug 4, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to fix the issues in #87 so this won't be needed.
Turns out that was the nise project. I'll update the Node versions here as well.

But thank you for good comments!

function getOwnPropertyDescriptors(obj) {
var propertyNames = Object.getOwnPropertyNames(obj);
var result = {};
propertyNames.forEach(function (name) {
var descriptor = Object.getOwnPropertyDescriptor(obj, name);
result[name] = descriptor;
});

return result;
}

// We use a set up function instead of beforeEach to avoid Mocha's check leaks detector
function setUpGlobal() {
// Configuration taken from from here https://github.com/airbnb/enzyme/blob/master/docs/guides/jsdom.md
var dom = new jsdom.JSDOM("<!doctype html><html><body></body></html>");
var window = dom.window;

function copyProps(src, target) {
originalDescriptors = getOwnPropertyDescriptors(target);
Object.defineProperties(target, getOwnPropertyDescriptors(src));
Object.defineProperties(target, originalDescriptors);
}

global.window = window;
global.document = window.document;
global.navigator = {
userAgent: "node.js"
};
global.requestAnimationFrame = function (callback) {
return setTimeout(callback, 0);
};
global.cancelAnimationFrame = function (id) {
clearTimeout(id);
};
copyProps(window, global);

withGlobal = lolex.withGlobal(global);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

}

function tearDownGlobal() {
var originalDescriptorNames = Object.keys(originalDescriptors);
var windowDescriptorNames = Object.getOwnPropertyNames(global.window);
windowDescriptorNames.forEach(function (descriptorName) {
if (!originalDescriptorNames.includes(descriptorName)) {
delete global[descriptorName];
}
});

delete global.window;
delete global.document;
delete global.navigator;
delete global.requestAnimationFrame;
delete global.cancelAnimationFrame;
}

it("correctly instantiates and tears down", function () {
setUpGlobal();

try {
var mockNow = new Date("1990-1-1");
var clock = withGlobal.install({
now: mockNow
});

assert.equals(new Date(Date.now()), mockNow);
assert.equals(new Date(), mockNow);

clock.uninstall();

assert(new Date().valueOf() !== mockNow.valueOf());
} finally {
tearDownGlobal();
}
});
});
18 changes: 16 additions & 2 deletions lolex.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,12 @@ function withGlobal(_global) {
} else if (method === "nextTick" && target.process) {
target.process.nextTick = clock[installedNextTick];
} else if (method === "performance") {
target[method] = clock["_" + method];
var originalPerfDescriptor = Object.getOwnPropertyDescriptor(clock, "_" + method);
if (originalPerfDescriptor && originalPerfDescriptor.get && !originalPerfDescriptor.set) {
Object.defineProperty(target, method, originalPerfDescriptor);
} else if (originalPerfDescriptor.configurable) {
target[method] = clock["_" + method];
}
} else {
if (target[method] && target[method].hadOwnProperty) {
target[method] = clock["_" + method];
Expand Down Expand Up @@ -452,7 +457,16 @@ function withGlobal(_global) {
var date = mirrorDateProperties(clock[method], target[method]);
target[method] = date;
} else if (method === "performance") {
target[method] = clock[method];
var originalPerfDescriptor = Object.getOwnPropertyDescriptor(target, method);
// JSDOM has a read only performance field so we have to save/copy it differently
if (originalPerfDescriptor && originalPerfDescriptor.get && !originalPerfDescriptor.set) {
Object.defineProperty(clock, "_" + method, originalPerfDescriptor);

var perfDescriptor = Object.getOwnPropertyDescriptor(clock, method);
Object.defineProperty(target, method, perfDescriptor);
} else {
target[method] = clock[method];
}
} else {
target[method] = function () {
return clock[method].apply(clock, arguments);
Expand Down
18 changes: 16 additions & 2 deletions src/lolex-src.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,12 @@ function withGlobal(_global) {
} else if (method === "nextTick" && target.process) {
target.process.nextTick = clock[installedNextTick];
} else if (method === "performance") {
target[method] = clock["_" + method];
var originalPerfDescriptor = Object.getOwnPropertyDescriptor(clock, "_" + method);
if (originalPerfDescriptor && originalPerfDescriptor.get && !originalPerfDescriptor.set) {
Object.defineProperty(target, method, originalPerfDescriptor);
} else if (originalPerfDescriptor.configurable) {
target[method] = clock["_" + method];
}
} else {
if (target[method] && target[method].hadOwnProperty) {
target[method] = clock["_" + method];
Expand Down Expand Up @@ -450,7 +455,16 @@ function withGlobal(_global) {
var date = mirrorDateProperties(clock[method], target[method]);
target[method] = date;
} else if (method === "performance") {
target[method] = clock[method];
var originalPerfDescriptor = Object.getOwnPropertyDescriptor(target, method);
// JSDOM has a read only performance field so we have to save/copy it differently
if (originalPerfDescriptor && originalPerfDescriptor.get && !originalPerfDescriptor.set) {
Object.defineProperty(clock, "_" + method, originalPerfDescriptor);

var perfDescriptor = Object.getOwnPropertyDescriptor(clock, method);
Object.defineProperty(target, method, perfDescriptor);
} else {
target[method] = clock[method];
}
} else {
target[method] = function () {
return clock[method].apply(clock, arguments);
Expand Down