Fix jsdom 2 #248
Merged
Fix jsdom 2 #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now without breaking some browsers
fatso83
approved these changes
Aug 4, 2019
| describe("globally configured browser objects", function () { | ||
| var withGlobal, originalDescriptors; | ||
|
|
||
| // Used to support Node 6 which doesn't support Object.getOwnPropertyDescriptors |
There was a problem hiding this comment.
I'll try to fix the issues in #87 so this won't be needed.
Turns out that was the nise project. I'll update the Node versions here as well.
But thank you for good comments!
| }; | ||
| copyProps(window, global); | ||
|
|
||
| withGlobal = lolex.withGlobal(global); |
fatso83
added a commit
that referenced
this pull request
Nov 9, 2021
Saw this was missing when reviewing DefinitelyTyped/DefinitelyTyped#56961 Bit funny that it has not been added until now, given it was added way back in #106 😄 (And later #169 #248 and others).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose (TL;DR) - mandatory
Fix #243 by changing the way the
performancefield gets overwritten. This time without breaking some browsers.Background (Problem in detail) - optional
JSDOM has a read only
performancefield. So, when JSDOM is configured to provide global values, lolex will error on init. This is because it can't overwrite the globalperformancefield.