Support legacy data directories #2846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawanjay176
approved these changes
Dec 1, 2021
| @@ -66,6 +66,15 @@ impl<E: EthSpec> ProductionBeaconNode<E> { | |||
| let freezer_db_path = client_config.create_freezer_db_path()?; | |||
| let executor = context.executor.clone(); | |||
|
|
|||
| if let Some(legacy_dir) = client_config.get_existing_legacy_data_dir() { | |||
| warn!( | |||
There was a problem hiding this comment.
This log comes up even for the default datadir (~/.lighthouse/<network>) which might cause unnecessary confusion. Perhaps we can skip the log for the default datadir?
There was a problem hiding this comment.
Ooh, good catch! No log when the legacy and default directory are the same!
|
Thanks @pawanjay176, I addressed your comment. Good catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
NA
Proposed Changes
Provides an alternate to #2843.
Enables backwards compatibility for data directories created prior to #2682.
Additional Info
NA