Fix db paths when datadir is relative to current path #2682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For the record, this might break users who are currently relying on the bug. I think it would worth changing the target to |
pawanjay176
force-pushed
the
relative-path-fix
branch
from
5c1c107 to
a0a3033
Compare
|
Changed the base branch to |
pawanjay176
force-pushed
the
relative-path-fix
branch
from
a0a3033 to
ce890dc
Compare
paulhauner
pushed a commit
that referenced
this pull request
Oct 12, 2021
paulhauner
pushed a commit
that referenced
this pull request
Oct 27, 2021
paulhauner
pushed a commit
to paulhauner/lighthouse
that referenced
this pull request
Nov 3, 2021
paulhauner
pushed a commit
that referenced
this pull request
Nov 11, 2021
paulhauner
pushed a commit
that referenced
this pull request
Nov 28, 2021
paulhauner
pushed a commit
that referenced
this pull request
Nov 28, 2021
Merged
paulhauner
pushed a commit
that referenced
this pull request
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
N/A
Proposed Changes
While running merge testnets, we noticed that passing relative paths for datadirs leads to the database directories being created relative to
$HOME. This PR fixes the issue such that database directories are generated relative to the datadir passed through cli or the default.