Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition issues with e2e tests for realtime-api #791

Merged
merged 20 commits into from
May 22, 2023

Conversation

iAmmar7
Copy link
Collaborator

@iAmmar7 iAmmar7 commented May 15, 2023

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented May 15, 2023

🦋 Changeset detected

Latest commit: f104116

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@signalwire/realtime-api Patch
@signalwire/core Patch
@signalwire/js Patch
@signalwire/web-api Patch
@signalwire/webrtc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@iAmmar7 iAmmar7 changed the base branch from main to dev May 15, 2023 18:00
@iAmmar7 iAmmar7 force-pushed the aa/e2e-race-conditions branch 15 times, most recently from f915f49 to 3f64076 Compare May 18, 2023 12:44
@iAmmar7 iAmmar7 force-pushed the aa/e2e-race-conditions branch from 3f64076 to 1535d4f Compare May 18, 2023 13:22
@iAmmar7 iAmmar7 force-pushed the aa/e2e-race-conditions branch from e70d139 to 4d31f76 Compare May 18, 2023 16:26
@iAmmar7 iAmmar7 force-pushed the aa/e2e-race-conditions branch from 4d31f76 to 2512bee Compare May 18, 2023 16:49
@iAmmar7 iAmmar7 changed the title WIP: Fix race condition issues with e2e tests for realtime-api Fix race condition issues with e2e tests for realtime-api May 18, 2023
@iAmmar7 iAmmar7 requested a review from edolix May 18, 2023 17:35
@iAmmar7 iAmmar7 force-pushed the aa/e2e-race-conditions branch 5 times, most recently from a21500b to 0ef84f9 Compare May 19, 2023 17:08
@iAmmar7 iAmmar7 force-pushed the aa/e2e-race-conditions branch from 0ef84f9 to f104116 Compare May 22, 2023 10:30
Copy link
Contributor

@edolix edolix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @iAmmar7 🙌

@edolix edolix merged commit a6b9f64 into dev May 22, 2023
@edolix edolix deleted the aa/e2e-race-conditions branch May 22, 2023 16:10
edolix pushed a commit that referenced this pull request May 22, 2023
* Fix race condition issues with e2e tests for realtime-api

* fix prompt type issue

* Caller and Callee wait for each other on each step

* sleep removed from the voice tap e2e

* fix voice record e2e

* voice collect e2e

* voice record multiple

* voice detect event

* encap the outbound call within try catch

* removed unnecessary wait

* fix call detect e2e

* enable all test cases

* fix voice peer call with promise

* fix voice prompt

* improve voice test

* enable all the CI jobs

* remove sleep for video api

* handled failed state for calling.call.connect event

* enable all the pipelines

* include changeset
edolix pushed a commit that referenced this pull request May 22, 2023
* Fix race condition issues with e2e tests for realtime-api

* fix prompt type issue

* Caller and Callee wait for each other on each step

* sleep removed from the voice tap e2e

* fix voice record e2e

* voice collect e2e

* voice record multiple

* voice detect event

* encap the outbound call within try catch

* removed unnecessary wait

* fix call detect e2e

* enable all test cases

* fix voice peer call with promise

* fix voice prompt

* improve voice test

* enable all the CI jobs

* remove sleep for video api

* handled failed state for calling.call.connect event

* enable all the pipelines

* include changeset
edolix pushed a commit that referenced this pull request May 22, 2023
* Fix race condition issues with e2e tests for realtime-api

* fix prompt type issue

* Caller and Callee wait for each other on each step

* sleep removed from the voice tap e2e

* fix voice record e2e

* voice collect e2e

* voice record multiple

* voice detect event

* encap the outbound call within try catch

* removed unnecessary wait

* fix call detect e2e

* enable all test cases

* fix voice peer call with promise

* fix voice prompt

* improve voice test

* enable all the CI jobs

* remove sleep for video api

* handled failed state for calling.call.connect event

* enable all the pipelines

* include changeset
edolix pushed a commit that referenced this pull request Jun 6, 2023
* EventEmitter for each instance of a component (#754)

* EventEmitter for each instance of a component

* remove branch from the main workflow

* add changeset

* add dev branch to workflow

* add dev branch to ci/cd

* Parent voice call worker to fork child call workers (#762)

* Calling worker to fork call workers

* hanlde calling.call.state events

* handle calling.call.dial event and move dial function to the client

* fix answer() promise

* handle calling.call.collect event

* hanlde calling.call.send_digits event

* handle calling.call.detect event

* handle calling.call.tap event

* handle calling.call.prompt event

* handle calling.call.connect event

* override on, once, and off functions for the Call

* replace _on with on in e2e test cases

* include changeset

* fix playback event for prompt

* fix call.detect event with internal sdk worker

* unit test cases fix

* rebased with the dev

* replace overriden functions

* fix instanceMap arg

---------

Co-authored-by: edolix <[email protected]>

* GH Action jobs should not run on  push (#780)

* Cleanup emitter transform for Voice Call APIs (#781)

* Cleanup emitter transform for Voice Call APIs

* include changeset

* Use base event emitter for Message API (#782)

* Use base event emitter for Message API

* emitter transform remove and changeset include

* ApplyEventListeners comment update

* Use base event emitter for Chat & PubSub API (#783)

* base emitter for chat and pubsub api

* changeset included

* improve pubsub and chat worker initializing

* fix chat and pubsub e2e js case

* improve chat and pubsub e2e js case

* SDK child worker type fix

* type issues fix for sub workers

* more debug

* more debug in voiceCallPlayWorker

* update payload from voiceCallDialWorker

* run only voice test for now

* override event listeners for call instances

* fix node script

* fix voiceCallConnectWorker bug

* fix test cases for playback and recording

---------

Co-authored-by: edolix <[email protected]>

* Use base event emitter for realtime video API (#784)

* Use base event emitter for realtime Video API

* videoMember worker initiated

* internal sdk video event to resolve getRoomSessions promise

* internal sdk event to resolve getRoomSessionById promise

* handle video.playback events with base emitter

* room session playback functions for realtime-api

* handle video.recording events and shared methods

* custom video.member events with backward compatibilty

* handle video stream events and methods

* handle layout event from the server

* video room audience count event

* worker introduced to inject instances in the instance map

* validation for instances in injectInInstanceMapWorker

* return value fix for play and recording functions

* fix unit test case for video class

* expose intanceMap through BaseComponent and remove injectInInstanceMap worker

* removed emitter transform from the RoomSession object and fix RoomSessionMember unit tests

* unit tests for room session playback, recording, and stream classes

* comments for stream class

* video room sdk worker removed and related types

* add playground with DTMF loop

* review changesets

* Fix race condition issues with e2e tests for realtime-api (#791)

* Fix race condition issues with e2e tests for realtime-api

* fix prompt type issue

* Caller and Callee wait for each other on each step

* sleep removed from the voice tap e2e

* fix voice record e2e

* voice collect e2e

* voice record multiple

* voice detect event

* encap the outbound call within try catch

* removed unnecessary wait

* fix call detect e2e

* enable all test cases

* fix voice peer call with promise

* fix voice prompt

* improve voice test

* enable all the CI jobs

* remove sleep for video api

* handled failed state for calling.call.connect event

* enable all the pipelines

* include changeset

* review changesets [skip ci]

* Trigger CI

* reduce logs

* just add feedback in playground

* Use instance map for Voice APIs instance creation (#799)

* Use instance map for Voice APIs instance creation

* changeset include

* Remove instance when action ended (#802)

* Remove instance when action ended

* remove comment from the videoRoomWorker

* Fix types for component's payload object (#801)

* Fix types for component's payload object

* fix build issue

* include BaseComponentOptionsWithPayload interface

* Override attach events function for BasePubSub (#804)

* Return RoomSessionMember object instead of plain Member object in realtime-api (#803)

* Return RoomSessionMember object instead of plain Member object

* fix build bug

* include changeset

* fix build

---------

Co-authored-by: Ammar Ansari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants