Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review internal workers and emitter transforms #776

Merged
merged 20 commits into from
Jun 6, 2023
Merged

Review internal workers and emitter transforms #776

merged 20 commits into from
Jun 6, 2023

Conversation

edolix
Copy link
Contributor

@edolix edolix commented Mar 31, 2023

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Mar 31, 2023

🦋 Changeset detected

Latest commit: 501a5f0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@signalwire/core Patch
@signalwire/realtime-api Patch
@sw-internal/playground-realtime-api Patch
@sw-internal/e2e-realtime-api Patch
@sw-internal/e2e-js Patch
@signalwire/js Patch
@signalwire/web-api Patch
@signalwire/webrtc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@edolix
Copy link
Contributor Author

edolix commented Apr 3, 2023

(rebased)

@edolix edolix changed the title WIP: Review Review internal workers and emitter transforms May 22, 2023
@edolix edolix force-pushed the dev branch 2 times, most recently from cdebf6e to 2703f14 Compare May 22, 2023 17:43
iAmmar7 and others added 12 commits May 22, 2023 19:45
* EventEmitter for each instance of a component

* remove branch from the main workflow

* add changeset

* add dev branch to workflow

* add dev branch to ci/cd
* Calling worker to fork call workers

* hanlde calling.call.state events

* handle calling.call.dial event and move dial function to the client

* fix answer() promise

* handle calling.call.collect event

* hanlde calling.call.send_digits event

* handle calling.call.detect event

* handle calling.call.tap event

* handle calling.call.prompt event

* handle calling.call.connect event

* override on, once, and off functions for the Call

* replace _on with on in e2e test cases

* include changeset

* fix playback event for prompt

* fix call.detect event with internal sdk worker

* unit test cases fix

* rebased with the dev

* replace overriden functions

* fix instanceMap arg

---------

Co-authored-by: edolix <[email protected]>
* Cleanup emitter transform for Voice Call APIs

* include changeset
* Use base event emitter for Message API

* emitter transform remove and changeset include

* ApplyEventListeners comment update
* base emitter for chat and pubsub api

* changeset included

* improve pubsub and chat worker initializing

* fix chat and pubsub e2e js case

* improve chat and pubsub e2e js case

* SDK child worker type fix

* type issues fix for sub workers

* more debug

* more debug in voiceCallPlayWorker

* update payload from voiceCallDialWorker

* run only voice test for now

* override event listeners for call instances

* fix node script

* fix voiceCallConnectWorker bug

* fix test cases for playback and recording

---------

Co-authored-by: edolix <[email protected]>
* Use base event emitter for realtime Video API

* videoMember worker initiated

* internal sdk video event to resolve getRoomSessions promise

* internal sdk event to resolve getRoomSessionById promise

* handle video.playback events with base emitter

* room session playback functions for realtime-api

* handle video.recording events and shared methods

* custom video.member events with backward compatibilty

* handle video stream events and methods

* handle layout event from the server

* video room audience count event

* worker introduced to inject instances in the instance map

* validation for instances in injectInInstanceMapWorker

* return value fix for play and recording functions

* fix unit test case for video class

* expose intanceMap through BaseComponent and remove injectInInstanceMap worker

* removed emitter transform from the RoomSession object and fix RoomSessionMember unit tests

* unit tests for room session playback, recording, and stream classes

* comments for stream class

* video room sdk worker removed and related types
* Fix race condition issues with e2e tests for realtime-api

* fix prompt type issue

* Caller and Callee wait for each other on each step

* sleep removed from the voice tap e2e

* fix voice record e2e

* voice collect e2e

* voice record multiple

* voice detect event

* encap the outbound call within try catch

* removed unnecessary wait

* fix call detect e2e

* enable all test cases

* fix voice peer call with promise

* fix voice prompt

* improve voice test

* enable all the CI jobs

* remove sleep for video api

* handled failed state for calling.call.connect event

* enable all the pipelines

* include changeset
edolix and others added 6 commits May 22, 2023 19:55
* Use instance map for Voice APIs instance creation

* changeset include
* Remove instance when action ended

* remove comment from the videoRoomWorker
* Fix types for component's payload object

* fix build issue

* include BaseComponentOptionsWithPayload interface
iAmmar7 and others added 2 commits June 5, 2023 13:50
…ltime-api (#803)

* Return RoomSessionMember object instead of plain Member object

* fix build bug

* include changeset
@edolix edolix merged commit 602921a into main Jun 6, 2023
@edolix edolix deleted the dev branch June 6, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants