Resolve the .ended() promise in case of call failure
#732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cbf85e9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
iAmmar7
changed the title
ended promise in case of call failure.ended() promise in case of call failure
edolix
reviewed
Feb 6, 2023
edolix
changed the title
.ended() promise in case of call failure.ended() promise in case of call failure
edolix
changed the title
.ended() promise in case of call failure.ended() promise in case of call failure
edolix
force-pushed
the
aa/ended-failure
branch
from
e40db1c to
cbf85e9
Compare
|
Rebased |
edolix
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this issue.
Handle the
.ended()promise for Playback functionHandle the
.ended()promise for Prompt functionHandle the
.ended()promise for Recording functionHandle the
.ended()promise for Detect functionHandle the
.ended()promise for Collect functionHandle the
.ended()promise for Tap functione2e test cases for Playback function
e2e test cases for Prompt function
e2e test cases for Detect function
e2e test cases for Tap function
e2e test cases for Recording function