Handle voice playback failure #731
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5d69bb8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
edolix
reviewed
Jan 27, 2023
| @@ -104,6 +104,10 @@ export class CallPlaybackAPI | |||
| } | |||
|
|
|||
| ended() { | |||
| if (['finished', 'error'].includes(this.state)) { | |||
There was a problem hiding this comment.
Nitpick: Can you create a const at the top with the states to check? Like ENDED_STATES = [...]
| resolve(true) | ||
| }) | ||
| }) | ||
| await waitForPlaybackEnded |
There was a problem hiding this comment.
As discussed already: lets add a comment explaining the logic in here since the playback ends because the inbound call hangup.
There was a problem hiding this comment.
Done ✅ Let me know if I can improve it further
|
See #732 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On playback failure
playback.failedevent to the end-user,This PR also includes an e2e test case for the playback function.