feat: make probe always open blockdevices in readonly mode #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/approve |
Fixes: siderolabs#44 Signed-off-by: Artem Chernyshev <[email protected]>
Unix4ever
force-pushed
the
probe-readonly
branch
from
a9cf3be to
e367f9d
Compare
smira
approved these changes
Sep 22, 2021
| @@ -149,7 +149,7 @@ func probe(devpath string) (devpaths []string) { | |||
| // Start by opening the block device. | |||
| // If a partition table was not found, it is still possible that a | |||
| // file system exists without a partition table. | |||
| bd, err := blockdevice.Open(devpath) | |||
| bd, err := blockdevice.Open(devpath, blockdevice.WithMode(blockdevice.ReadonlyMode)) | |||
There was a problem hiding this comment.
I hope we don't write to probed devices later? (I don't know if there's any good chance to track through it?)
There was a problem hiding this comment.
I've checked the code, it doesn't look like we do. I'm going to run integration tests in Talos now to see if anything got broken.
|
/m --ff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #44
Signed-off-by: Artem Chernyshev [email protected]