Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open disk in read/write mode #44

Closed
sergelogvinov opened this issue Sep 14, 2021 · 0 comments · Fixed by #45
Closed

Open disk in read/write mode #44

sergelogvinov opened this issue Sep 14, 2021 · 0 comments · Fixed by #45
Assignees
@Unix4ever

Comments

@sergelogvinov
Copy link

The probePartitions very good function to fine partition by LABEL. But if partition exist on CDROM drive this function cannot open disk in RW mode.

Should Talos open disk in that mode?

https://github.com/talos-systems/go-blockdevice/blob/d9811569588ba44be878a00ce316f59a37abed8b/blockdevice/blockdevice_linux.go#L51-L53

Open disk in readonly mode will help me to solve such problems:

https://github.com/talos-systems/talos/pull/4208/files#diff-56bcd8b6a4ae3a3ab4e9c6b00620c389a03c2f6bcd584eb3e2ab495b89559c3cR317-R340
@Unix4ever Unix4ever self-assigned this Sep 22, 2021
Unix4ever added a commit to Unix4ever/go-blockdevice that referenced this issue Sep 22, 2021
@Unix4ever
feat: make probe always open blockdevices in readonly mode
a9cf3be 
Fixes: siderolabs#44

Signed-off-by: Artem Chernyshev <[email protected]>
@Unix4ever Unix4ever mentioned this issue Sep 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Unix4ever Unix4ever

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: make probe always open blockdevices in readonly mode Unix4ever/go-blockdevice
2 participants
@Unix4ever @sergelogvinov