Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] 基于 v2.x 重构 v3.x #34

Merged
merged 9 commits into from
Dec 27, 2024
Merged

Conversation

jamesnulliu
Copy link
Member

@jamesnulliu jamesnulliu commented Dec 27, 2024

Updates

  • 重构项目目录.
  • 增加 bash 编译脚本.
  • 增加 CD: Release.

Bug Fixes

@jamesnulliu jamesnulliu added the enhancement New feature or request label Dec 27, 2024
@Errant404
Copy link
Member

Errant404 commented Dec 27, 2024

LGTM! But I think the build script should be placed in the project root directory.

@Errant404
Copy link
Member

Errant404 commented Dec 27, 2024

@LuminolT, do you have any comments? If not, I will proceed with the Squash merge.

@LuminolT
Copy link
Collaborator

Thanks @jamesnulliu for your contribution.

@Errant404, I have reviewed the PR. It works on my local environment (Endeavor OS).

However, I still have a few concerns:

First, I noticed that the Makefile and shuthesis.dtx files are removed. These are part of the process that generates the shuthesis.pdf documentation. Although we might not actively use it anymore, they might still need to be preserved (or archived).

Second, some half-width characters were replaced with full-width ones, e.g. . -> and , -> . This could be related to the thesis writing guidelines. I'm not sure whether certain departments (especially the Mathematics Department) have specific requirements regarding the use of half-width characters.

These issues need further discussion, so please refrain from merging for now.

Copy link
Collaborator

@LuminolT LuminolT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have further reviewed the related issues.

Regarding the first problem, although this modification approach will increase the difficulty of subsequent low-level configurations, overall, it will work, and there are no issues.

As for the second one, based on the GB/T 7713.1-2006 national standard, changing to full-width characters is perfectly acceptable.

@Errant404 please go ahead and merge this PR if there are no further issues. THX!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

论文英语部分字体问题 摘要部分的字体问题
3 participants