-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] 基于 v2.x 重构 v3.x #34
Conversation
LGTM! But I think the build script should be placed in the project root directory. |
@LuminolT, do you have any comments? If not, I will proceed with the Squash merge. |
Thanks @jamesnulliu for your contribution. @Errant404, I have reviewed the PR. It works on my local environment (Endeavor OS). However, I still have a few concerns: First, I noticed that the Second, some half-width characters were replaced with full-width ones, e.g. These issues need further discussion, so please refrain from merging for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have further reviewed the related issues.
Regarding the first problem, although this modification approach will increase the difficulty of subsequent low-level configurations, overall, it will work, and there are no issues.
As for the second one, based on the GB/T 7713.1-2006 national standard, changing to full-width characters is perfectly acceptable.
@Errant404 please go ahead and merge this PR if there are no further issues. THX!
Updates
Bug Fixes