Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] shopinvader_customer_price_wishlist: Migration to 14.0 #901

Conversation

chafique-delli
Copy link
Contributor

@chafique-delli chafique-delli commented Mar 1, 2021

@sebastienbeau sebastienbeau added this to the 14.0 milestone Jul 21, 2021
@kevinkhao kevinkhao force-pushed the 14.0-mig-shopinvader_customer_price_wishlist branch from 778b0b6 to cc7aa29 Compare October 6, 2021 20:30
@simahawk
Copy link
Contributor

simahawk commented Oct 7, 2021

@kevinkhao can you rebase? Should fix tests

@kevinkhao kevinkhao force-pushed the 14.0-mig-shopinvader_customer_price_wishlist branch from cc7aa29 to bd646c1 Compare October 7, 2021 08:02
@kevinkhao
Copy link
Contributor

kevinkhao commented Oct 7, 2021

renamed testcase here #1142

@simahawk
Copy link
Contributor

simahawk commented Oct 8, 2021

@kevinkhao #1142 is getting merged

@kevinkhao kevinkhao force-pushed the 14.0-mig-shopinvader_customer_price_wishlist branch from bd646c1 to f71bf2f Compare October 8, 2021 09:37
@simahawk
Copy link
Contributor

@kevinkhao could you check the build?

2021-10-08 09:52:20,977 422 ERROR odoo odoo.addons.shopinvader_customer_price_wishlist.tests.test_wishlist_price: ERROR: WishlistCase.test_jsonify_custom_pricelist
Traceback (most recent call last):
  File "/__w/odoo-shopinvader/odoo-shopinvader/shopinvader_customer_price_wishlist/tests/test_wishlist_price.py", line 53, in test_jsonify_custom_pricelist
    self.discount_pricelist, self.backend._get_fiscal_position(self.partner)
  File "/__w/odoo-shopinvader/odoo-shopinvader/shopinvader_product_price_tax/models/shopinvader_variant.py", line 13, in _get_price
    qty=qty, pricelist=pricelist, fposition=fposition, company=company
  File "/__w/odoo-shopinvader/odoo-shopinvader/shopinvader/models/shopinvader_variant.py", line 242, in _get_price
    if pricelist and pricelist.discount_policy == "without_discount":
AttributeError: 'account.fiscal.position' object has no attribute 'discount_policy'

@kevinkhao kevinkhao force-pushed the 14.0-mig-shopinvader_customer_price_wishlist branch from f71bf2f to 85ba9fc Compare October 15, 2021 12:26
@kevinkhao kevinkhao force-pushed the 14.0-mig-shopinvader_customer_price_wishlist branch 2 times, most recently from f931293 to 8018354 Compare October 15, 2021 13:39
@kevinkhao
Copy link
Contributor

function signature changed with named arguments
I put the named arguments

@simahawk
Copy link
Contributor

/ocabot merge nobump

@shopinvader-git-bot
Copy link

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-901-by-simahawk-bump-nobump, awaiting test results.

@shopinvader-git-bot
Copy link

Congratulations, your PR was merged at cdc814c. Thanks a lot for contributing to shopinvader. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants