[MIG] shopinvader_customer_price: Migration to 14.0 #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chafique-delli
force-pushed
the
14.0-mig-shopinvader_customer_price
branch
3 times, most recently
from
0fa7318 to
7438354
Compare
|
@chafique-delli it would be nice to merge this first #803 |
1 task
|
pls:
|
PierrickBrun
force-pushed
the
14.0-mig-shopinvader_customer_price
branch
3 times, most recently
from
6a21c52 to
774a719
Compare
simahawk
reviewed
Jul 16, 2021
PierrickBrun
force-pushed
the
14.0-mig-shopinvader_customer_price
branch
from
774a719 to
148f9c4
Compare
simahawk
approved these changes
Jul 19, 2021
simahawk
approved these changes
Jul 22, 2021
|
ping :) |
Fiscal position and pricelist lookup belong to the backend because that's where you can configure params that could affect them. Plus, it makes easier to cache them.
PierrickBrun
force-pushed
the
14.0-mig-shopinvader_customer_price
branch
from
148f9c4 to
6bdc884
Compare
|
@simahawk done |
|
thanks! /ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 218c81c. Thanks a lot for contributing to shopinvader. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends of : #897