Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][PORT] 561 from 10.0 #773

Merged
merged 2 commits into from
Jan 25, 2021
Merged

[13.0][PORT] 561 from 10.0 #773

merged 2 commits into from
Jan 25, 2021

Conversation

sebastienbeau
Copy link
Contributor

Port #561 from 10.0 to 13.0.

@lmignon lmignon mentioned this pull request Sep 1, 2020
Closed
77 tasks
@sebastienbeau
Copy link
Contributor Author

sebastienbeau commented Sep 1, 2020 •
edited by simahawk
Loading

Forward port fail as this PR already add the field #734
TODO we need to check if we do not miss some feature between the two implementation

@sebastienbeau sebastienbeau force-pushed the 13.0-561-port branch 4 times, most recently from 6eb7982 to 036653f Compare November 20, 2020 22:32
@codecov-io
Copy link

codecov-io commented Jan 25, 2021 •
edited
Loading

Codecov Report

Merging #773 (c3327e0) into 13.0 (92f20e1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             13.0     #773   +/-   ##
=======================================
  Coverage   91.63%   91.63%           
=======================================
  Files         145      145           
  Lines        4636     4638    +2     
=======================================
+ Hits         4248     4250    +2     
  Misses        388      388
Impacted Files Coverage Δ
shopinvader/services/address.py 93.97% <100.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92f20e1...c3327e0. Read the comment docs.

simahawk
simahawk reviewed Jan 25, 2021
View reviewed changes
shopinvader/services/address.py Outdated
"type": {
"type": "string",
"allowed": self._get_allowed_type(),
"default": "other",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe "contact" is better as default?

@shopinvader-git-bot
Copy link

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@sebastienbeau
Copy link
Contributor Author

/ocabot merge minor

@shopinvader-git-bot
Copy link

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-773-by-sebastienbeau-bump-minor, awaiting test results.

@shopinvader-git-bot shopinvader-git-bot merged commit ace9131 into shopinvader:13.0 Jan 25, 2021
@shopinvader-git-bot
Copy link

Congratulations, your PR was merged at 0540b91. Thanks a lot for contributing to shopinvader. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simahawk simahawk simahawk approved these changes

@PierrickBrun PierrickBrun PierrickBrun approved these changes

Assignees
No one assigned
Labels
13.0 approved forwardport help wanted merged 🎉 needs fixing ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sebastienbeau @codecov-io @shopinvader-git-bot @simahawk @PierrickBrun @rousseldenis