Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IMP address: allow passing type + email, expose parent_id #734

Merged
merged 1 commit into from
Aug 29, 2020
Merged

IMP address: allow passing type + email, expose parent_id #734

merged 1 commit into from
Aug 29, 2020

Conversation

simahawk
Copy link
Contributor

No description provided.

@simahawk
Copy link
Contributor Author

simahawk commented Aug 14, 2020 •
edited
Loading

BTW address_type which is used to distinguish between a profile (meaning customer) and an address (meaning a child partner) has a very misleading name. IMO we should change it in backward compat way sooner or later (eg: partner_type or kind or shop_type).

@simahawk
Copy link
Contributor Author

/ocabot merge minor

@shopinvader-git-bot
Copy link

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-734-by-simahawk-bump-minor, awaiting test results.

@shopinvader-git-bot shopinvader-git-bot merged commit b2c1ec6 into shopinvader:13.0 Aug 29, 2020
@shopinvader-git-bot
Copy link

Congratulations, your PR was merged at 67f470a. Thanks a lot for contributing to shopinvader. ❤️

@simahawk simahawk mentioned this pull request Sep 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i-vyshnevska i-vyshnevska i-vyshnevska approved these changes

Assignees
No one assigned
Labels
13.0 merged 🎉 needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simahawk @shopinvader-git-bot @i-vyshnevska