Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][PORT] 572 from 10.0 #700

Merged
merged 2 commits into from
Nov 20, 2020
Merged

[13.0][PORT] 572 from 10.0 #700

merged 2 commits into from
Nov 20, 2020

Conversation

sebastienbeau
Copy link
Contributor

Port #572 from 10.0 to 13.0.

@lmignon lmignon mentioned this pull request Jun 19, 2020
Closed
77 tasks
@sebastienbeau
Copy link
Contributor Author

/ocabot merge nobump

@shopinvader-git-bot
Copy link

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-700-by-sebastienbeau-bump-nobump, awaiting test results.

shopinvader-git-bot pushed a commit that referenced this pull request Jun 19, 2020
Merge PR #700 into 13.0
cb4113a 
Signed-off-by sebastienbeau
@shopinvader-git-bot
Copy link

@sebastienbeau your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-700-by-sebastienbeau-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

Cédric Pigeon and others added 2 commits November 20, 2020 18:41
@sebastienbeau
add new addon to allow to display the category image if the product d…
44267de 
…oes not have one
@sebastienbeau
[MIG] migrate to 13.0
ca6b164 
remove depends as field is not stored and reading field on shopinvader.variant is a readonly process only
@codecov-io
Copy link

codecov-io commented Nov 20, 2020 •
edited
Loading

Codecov Report

Merging #700 (ca6b164) into 13.0 (610e1ce) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             13.0     #700      +/-   ##
==========================================
+ Coverage   91.23%   91.32%   +0.08%     
==========================================
  Files         141      142       +1     
  Lines        4517     4529      +12     
==========================================
+ Hits         4121     4136      +15     
+ Misses        396      393       -3
Impacted Files Coverage Δ
...ry_image_for_product/models/shopinvader_variant.py 100.00% <100.00%> (ø)
...er_locomotive_algolia/models/se_backend_algolia.py 100.00% <0.00%> (+33.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 610e1ce...ca6b164. Read the comment docs.

@sebastienbeau
Copy link
Contributor Author

/ocabot merge nobump

@shopinvader-git-bot
Copy link

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-700-by-sebastienbeau-bump-nobump, awaiting test results.

shopinvader-git-bot pushed a commit that referenced this pull request Nov 20, 2020
Merge PR #700 into 13.0
5cfb066 
Signed-off-by sebastienbeau
@shopinvader-git-bot
Copy link

It looks like something changed on 13.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 13.0-ocabot-merge-pr-700-by-sebastienbeau-bump-nobump, awaiting test results.

@shopinvader-git-bot shopinvader-git-bot merged commit 6cf9e27 into shopinvader:13.0 Nov 20, 2020
@shopinvader-git-bot
Copy link

Congratulations, your PR was merged at ce6ff4a. Thanks a lot for contributing to shopinvader. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
forwardport merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sebastienbeau @shopinvader-git-bot @codecov-io