Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.0] add new addon to allow to display the category image if the product does not have one #572

Merged
merged 1 commit into from
Mar 20, 2020
Merged

[10.0] add new addon to allow to display the category image if the product does not have one #572

merged 1 commit into from
Mar 20, 2020

Conversation

Cedric-Pigeon
Copy link

No description provided.

@Cedric-Pigeon Cedric-Pigeon force-pushed the 10.0-category_image-cpi branch from 728768b to 9510d02 Compare February 6, 2020 11:23
@Cedric-Pigeon Cedric-Pigeon force-pushed the 10.0-category_image-cpi branch from 9510d02 to e227649 Compare February 7, 2020 13:14
@codecov-io
Copy link

codecov-io commented Feb 7, 2020 •
edited
Loading

Codecov Report

Merging #572 into 10.0 will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             10.0     #572      +/-   ##
==========================================
+ Coverage   89.61%   89.64%   +0.03%     
==========================================
  Files         142      143       +1     
  Lines        3735     3748      +13     
==========================================
+ Hits         3347     3360      +13     
  Misses        388      388
Impacted Files Coverage Δ
...ry_image_for_product/models/shopinvader_variant.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ddd44c...43296bd. Read the comment docs.

@Cedric-Pigeon Cedric-Pigeon force-pushed the 10.0-category_image-cpi branch from e227649 to 5d7dbb6 Compare February 7, 2020 14:15
@Cedric-Pigeon Cedric-Pigeon force-pushed the 10.0-category_image-cpi branch from 5d7dbb6 to 43296bd Compare February 7, 2020 14:33
rousseldenis
rousseldenis approved these changes Feb 12, 2020
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@rousseldenis rousseldenis added this to the 10.0 milestone Feb 12, 2020
@Cedric-Pigeon
Copy link
Author

@simahawk Are you still waiting something from me on this one?

@shopinvader-git-bot
Copy link

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rousseldenis
Copy link
Contributor

/ocabot merge

@shopinvader-git-bot
Copy link

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 10.0-ocabot-merge-pr-572-by-rousseldenis-bump-no, awaiting test results.

shopinvader-git-bot pushed a commit that referenced this pull request Mar 19, 2020
Merge PR #572 into 10.0
8d1dce5 
Signed-off-by rousseldenis
@lmignon lmignon mentioned this pull request Mar 19, 2020
Closed
77 tasks
@shopinvader-git-bot
Copy link

It looks like something changed on 10.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 10.0-ocabot-merge-pr-572-by-rousseldenis-bump-no, awaiting test results.

shopinvader-git-bot pushed a commit that referenced this pull request Mar 19, 2020
Merge PR #572 into 10.0
d797e16 
Signed-off-by rousseldenis
@shopinvader-git-bot
Copy link

It looks like something changed on 10.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 10.0-ocabot-merge-pr-572-by-rousseldenis-bump-no, awaiting test results.

shopinvader-git-bot pushed a commit that referenced this pull request Mar 19, 2020
Merge PR #572 into 10.0
f971dfb 
Signed-off-by rousseldenis
@shopinvader-git-bot
Copy link

It looks like something changed on 10.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 10.0-ocabot-merge-pr-572-by-rousseldenis-bump-no, awaiting test results.

shopinvader-git-bot pushed a commit that referenced this pull request Mar 19, 2020
Merge PR #572 into 10.0
f4c33e0 
Signed-off-by rousseldenis
@shopinvader-git-bot
Copy link

@rousseldenis your merge command was aborted due to failed check(s), which you can inspect on this commit of 10.0-ocabot-merge-pr-572-by-rousseldenis-bump-no.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@Cedric-Pigeon
Copy link
Author

/ocabot merge

@shopinvader-git-bot
Copy link

This PR looks fantastic, let's merge it!
Prepared branch 10.0-ocabot-merge-pr-572-by-Cedric-Pigeon-bump-no, awaiting test results.

@shopinvader-git-bot shopinvader-git-bot merged commit 50bac49 into shopinvader:10.0 Mar 20, 2020
@shopinvader-git-bot
Copy link

Congratulations, your PR was merged at f344e40. Thanks a lot for contributing to shopinvader. ❤️

@sbidoul sbidoul deleted the 10.0-category_image-cpi branch March 20, 2020 07:26
This was referenced Jun 19, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simahawk simahawk simahawk approved these changes

@sebastienbeau sebastienbeau sebastienbeau approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review ready to merge
Projects
None yet
Milestone
10.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Cedric-Pigeon @codecov-io @shopinvader-git-bot @rousseldenis @simahawk @sebastienbeau