Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12.0][PORT] #558 from 10.0 to 12.0: Allow to copy a previous sale #655

Merged
merged 2 commits into from
May 28, 2020
Merged

[12.0][PORT] #558 from 10.0 to 12.0: Allow to copy a previous sale #655

merged 2 commits into from
May 28, 2020

Conversation

HviorForgeFlow
Copy link
Contributor

Port #558 from 10.0 to 12.0

@rousseldenis @HviorForgeFlow
shopinvader: Allow to copy a previous sale
3eee6c7 
This allows to copy a previous confirmed cart to a new one.
If there is an existing cart, it will be replaced.
@rousseldenis @HviorForgeFlow
shopinvader_delivery_carrier: Don't copy delivery lines
6d269a0
@HviorForgeFlow HviorForgeFlow changed the title [12.0][PORT] #558 from 10.0 to 12.0 [12.0][PORT] #558 from 10.0 to 12.0: Allow to copy a previous sale May 25, 2020
@codecov-commenter
Copy link

codecov-commenter commented May 25, 2020 •
edited
Loading

Codecov Report

Merging #655 into 12.0 will increase coverage by 0.00%.
The diff coverage is 92.59%.

Impacted file tree graph

@@           Coverage Diff           @@
##             12.0     #655   +/-   ##
=======================================
  Coverage   91.60%   91.61%           
=======================================
  Files         137      137           
  Lines        3907     3934   +27     
=======================================
+ Hits         3579     3604   +25     
- Misses        328      330    +2
Impacted Files Coverage Δ
shopinvader_delivery_carrier/services/cart.py 91.83% <33.33%> (-3.82%) ⬇️
shopinvader/services/cart.py 89.38% <100.00%> (+1.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f131c41...6d269a0. Read the comment docs.

@rousseldenis rousseldenis added this to the 12.0 milestone May 25, 2020
@lmignon lmignon mentioned this pull request May 26, 2020
Closed
77 tasks
@rousseldenis
Copy link
Contributor

/ocabot merge minor

@shopinvader-git-bot
Copy link

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-655-by-rousseldenis-bump-minor, awaiting test results.

@shopinvader-git-bot shopinvader-git-bot merged commit e7a7951 into shopinvader:12.0 May 28, 2020
@shopinvader-git-bot
Copy link

Congratulations, your PR was merged at 696fa42. Thanks a lot for contributing to shopinvader. ❤️

@HviorForgeFlow HviorForgeFlow deleted the 12.0-558-port branch May 28, 2020 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis approved these changes

Assignees
No one assigned
Labels
forwardport merged 🎉 needs review
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.
4 participants
@HviorForgeFlow @codecov-commenter @rousseldenis @shopinvader-git-bot