Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.0][IMP] shopinvader: Allow to copy a previous sale #558

Merged
merged 2 commits into from
Mar 23, 2020
Merged

[10.0][IMP] shopinvader: Allow to copy a previous sale #558

merged 2 commits into from
Mar 23, 2020

Conversation

rousseldenis
Copy link
Contributor

This allows to copy a previous confirmed cart to a new one.
If there is an existing cart, it will be replaced.

@rousseldenis
Copy link
Contributor Author

@Cedric-Pigeon @lmignon @sebastienbeau @simahawk

@rousseldenis rousseldenis force-pushed the 10.0-add-shopinvader_cart_copy-dro branch from 4914db4 to 583eb67 Compare January 17, 2020 10:46
@rousseldenis rousseldenis added this to the 10.0 milestone Jan 17, 2020
@rousseldenis rousseldenis force-pushed the 10.0-add-shopinvader_cart_copy-dro branch from 583eb67 to 2bd3c4d Compare January 17, 2020 14:43
@rousseldenis rousseldenis force-pushed the 10.0-add-shopinvader_cart_copy-dro branch from 2bd3c4d to af36e03 Compare January 29, 2020 12:20
@codecov-io
Copy link

codecov-io commented Jan 29, 2020 •
edited
Loading

Codecov Report

Merging #558 into 10.0 will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             10.0     #558      +/-   ##
==========================================
+ Coverage   89.61%   89.69%   +0.08%     
==========================================
  Files         142      142              
  Lines        3735     3757      +22     
==========================================
+ Hits         3347     3370      +23     
+ Misses        388      387       -1
Impacted Files Coverage Δ
shopinvader/services/cart.py 89.14% <100%> (+1.2%) ⬆️
shopinvader/models/sale.py 95.29% <0%> (+1.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ddd44c...81d36ef. Read the comment docs.

@rousseldenis
Copy link
Contributor Author

rousseldenis commented Jan 29, 2020 •
edited
Loading

  • Removed limitation to 'typology' == 'cart (so, can copy everything).
  • Add limitation to session partner's sale orders.

@rousseldenis rousseldenis force-pushed the 10.0-add-shopinvader_cart_copy-dro branch from af36e03 to 81d36ef Compare February 7, 2020 15:00
@Cedric-Pigeon
Copy link

@rousseldenis Can you check travis?

@rousseldenis rousseldenis force-pushed the 10.0-add-shopinvader_cart_copy-dro branch from 81d36ef to d7a6fe1 Compare March 19, 2020 09:13
@shopinvader-git-bot
Copy link

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

hparfr
hparfr approved these changes Mar 19, 2020
View reviewed changes
Copy link
Contributor

@hparfr hparfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sebastienbeau
sebastienbeau requested changes Mar 19, 2020
View reviewed changes
Copy link
Contributor

@sebastienbeau sebastienbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look at the issue during copy

@rousseldenis
[10.0][IMP] shopinvader: Allow to copy a previous sale
8698340 
This allows to copy a previous confirmed cart to a new one.
If there is an existing cart, it will be replaced.
@rousseldenis
[10.0][IMP] shopinvader_delivery_carrier: Don't copy delivery lines
52cc589
@rousseldenis rousseldenis force-pushed the 10.0-add-shopinvader_cart_copy-dro branch from d7a6fe1 to 52cc589 Compare March 23, 2020 09:56
sebastienbeau
sebastienbeau approved these changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@sebastienbeau sebastienbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work !

@Cedric-Pigeon
Copy link

/ocabot merge minor

@shopinvader-git-bot
Copy link

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 10.0-ocabot-merge-pr-558-by-Cedric-Pigeon-bump-minor, awaiting test results.

@shopinvader-git-bot
Copy link

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@shopinvader-git-bot shopinvader-git-bot merged commit dc6456b into shopinvader:10.0 Mar 23, 2020
@shopinvader-git-bot
Copy link

Congratulations, your PR was merged at a228c79. Thanks a lot for contributing to shopinvader. ❤️

@lmignon
Copy link
Collaborator

lmignon commented Mar 23, 2020

@Cedric-Pigeon don't forget to add the PR into the forward port issue...

@lmignon lmignon mentioned this pull request Mar 23, 2020
Closed
77 tasks
@Cedric-Pigeon
Copy link

@Cedric-Pigeon don't forget to add the PR into the forward port issue...

@lmignon I do not forget, I usually do it as soon as the merge is done ;-)

This was referenced May 25, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simahawk simahawk simahawk approved these changes

@sebastienbeau sebastienbeau sebastienbeau approved these changes

@Cedric-Pigeon Cedric-Pigeon Cedric-Pigeon approved these changes

@hparfr hparfr hparfr approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 needs review ready to merge
Projects
None yet
Milestone
10.0
Development

Successfully merging this pull request may close these issues.
8 participants
@rousseldenis @codecov-io @Cedric-Pigeon @shopinvader-git-bot @lmignon @simahawk @sebastienbeau @hparfr